From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] tools/xenconsoled: Initialise static data
	before use
Date: Fri, 8 Mar 2013 11:27:16 +0000
Message-ID: <5139CB14.1090807@citrix.com>
References: <803a5869bfb532aff605.1362681902@andrewcoop.uk.xensource.com>
	<20792.58265.365439.671985@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20792.58265.365439.671985@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 07/03/13 18:59, Ian Jackson wrote:
> Andrew Cooper writes ("[PATCH] tools/xenconsoled: Initialise static data before use"):
>> 'fds' and 'current_array_size' are used in a memset() in reset_fds(), and for
>> the first call to set_fds() before being initialised.
>>
>> Also initialise nr_fds for sanity sake.
> These variables have static storage duration and are therefore
> initialised to 0.
>
> Ian.

D'oh - I was not completely sure about this, double checked online and
managed to come up with the wrong answer.

My apologies.

The more concerning point is now "why does this appear to make a
difference"  I shall continue debugging.

~Andrew