All of lore.kernel.org
 help / color / mirror / Atom feed
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: davem@davemloft.net
Cc: Thomas Graf <tgraf@suug.ch>,
	netdev@vger.kernel.org,
	YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len
Date: Sat, 09 Mar 2013 01:31:53 +0900	[thread overview]
Message-ID: <513A1279.3040105@linux-ipv6.org> (raw)
In-Reply-To: <85f9fbce9b5a6ccc4e75b05dab268076e0574abf.1362740080.git.tgraf@suug.ch>

Thomas Graf wrote:
> send_sllao is already initialized with the value of dev->addr_len
> 
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> ---
>  net/ipv6/ndisc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index 76ef435..2712ab2 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -610,8 +610,6 @@ void ndisc_send_rs(struct net_device *dev, const struct in6_addr *saddr,
>  		}
>  	}
>  #endif
> -	if (!dev->addr_len)
> -		send_sllao = 0;
>  	if (send_sllao)
>  		optlen += ndisc_opt_addr_space(dev);
>  
> 
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

  reply	other threads:[~2013-03-08 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 11:03 [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len Thomas Graf
2013-03-08 16:31 ` YOSHIFUJI Hideaki [this message]
2013-03-08 17:30   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513A1279.3040105@linux-ipv6.org \
    --to=yoshfuji@linux-ipv6.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.