From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller Date: Fri, 08 Mar 2013 10:54:44 -0700 Message-ID: <513A25E4.8040504@wwwdotorg.org> References: <1362750782-15174-1-git-send-email-ldewangan@nvidia.com> <1362750782-15174-4-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1362750782-15174-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/08/2013 06:53 AM, Laxman Dewangan wrote: > Add APB DMA requestor and serial aliases for serial controller. > There will be two serial driver i.e. 8250 based simple serial driver > and APB DMA based serial driver for higher baudrate and performace. > > The simple serial driver get enabled with compatible nvidia,tegra20-uart > and APB DMA based driver will get enabled with compatible > nvidia,tegra30-hsuart. > > Also Fix the clock id for the UARTB. If you feel like saying "also", that should probably be a separate patch! In this case, if the UARTB clock ID actually should be changed, then the fix should be rolled into Peter's Tegra114 clock series, since it adds the property you're changing here, and his series hasn't yet been applied. But, as I mentioned in my previous email, I don't believe the UARTB clock ID change is correct. > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi > + /* > + * There are two serial driver i.e. 8250 based simple serial > + * driver and APB DMA based serial driver for higher baudrate > + * and performace. To enable the 8250 based driver, the compatible > + * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable > + * the APB DMA based serial driver, the comptible is > + * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". > + */ Any references to Tegra30 there should be changed to Tegra114 I think. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Fri, 08 Mar 2013 10:54:44 -0700 Subject: [PATCH 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller In-Reply-To: <1362750782-15174-4-git-send-email-ldewangan@nvidia.com> References: <1362750782-15174-1-git-send-email-ldewangan@nvidia.com> <1362750782-15174-4-git-send-email-ldewangan@nvidia.com> Message-ID: <513A25E4.8040504@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/08/2013 06:53 AM, Laxman Dewangan wrote: > Add APB DMA requestor and serial aliases for serial controller. > There will be two serial driver i.e. 8250 based simple serial driver > and APB DMA based serial driver for higher baudrate and performace. > > The simple serial driver get enabled with compatible nvidia,tegra20-uart > and APB DMA based driver will get enabled with compatible > nvidia,tegra30-hsuart. > > Also Fix the clock id for the UARTB. If you feel like saying "also", that should probably be a separate patch! In this case, if the UARTB clock ID actually should be changed, then the fix should be rolled into Peter's Tegra114 clock series, since it adds the property you're changing here, and his series hasn't yet been applied. But, as I mentioned in my previous email, I don't believe the UARTB clock ID change is correct. > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi > + /* > + * There are two serial driver i.e. 8250 based simple serial > + * driver and APB DMA based serial driver for higher baudrate > + * and performace. To enable the 8250 based driver, the compatible > + * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable > + * the APB DMA based serial driver, the comptible is > + * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". > + */ Any references to Tegra30 there should be changed to Tegra114 I think. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964789Ab3CHRyt (ORCPT ); Fri, 8 Mar 2013 12:54:49 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:39776 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933621Ab3CHRyr (ORCPT ); Fri, 8 Mar 2013 12:54:47 -0500 Message-ID: <513A25E4.8040504@wwwdotorg.org> Date: Fri, 08 Mar 2013 10:54:44 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Laxman Dewangan CC: linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, pdeschrijver@nvidia.com Subject: Re: [PATCH 3/5] ARM: DT: tegra114:add aliases and DMA requestor for serial controller References: <1362750782-15174-1-git-send-email-ldewangan@nvidia.com> <1362750782-15174-4-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1362750782-15174-4-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2013 06:53 AM, Laxman Dewangan wrote: > Add APB DMA requestor and serial aliases for serial controller. > There will be two serial driver i.e. 8250 based simple serial driver > and APB DMA based serial driver for higher baudrate and performace. > > The simple serial driver get enabled with compatible nvidia,tegra20-uart > and APB DMA based driver will get enabled with compatible > nvidia,tegra30-hsuart. > > Also Fix the clock id for the UARTB. If you feel like saying "also", that should probably be a separate patch! In this case, if the UARTB clock ID actually should be changed, then the fix should be rolled into Peter's Tegra114 clock series, since it adds the property you're changing here, and his series hasn't yet been applied. But, as I mentioned in my previous email, I don't believe the UARTB clock ID change is correct. > diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi > + /* > + * There are two serial driver i.e. 8250 based simple serial > + * driver and APB DMA based serial driver for higher baudrate > + * and performace. To enable the 8250 based driver, the compatible > + * is "nvidia,tegra30-uart", "nvidia,tegra20-uart" and to enable > + * the APB DMA based serial driver, the comptible is > + * "nvidia,tegra30-hsuart", "nvidia,tegra20-hsuart". > + */ Any references to Tegra30 there should be changed to Tegra114 I think.