From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 4/5] ARM: DT: tegra114: add KBC controller DT entry Date: Fri, 08 Mar 2013 11:42:27 -0700 Message-ID: <513A3113.10909@wwwdotorg.org> References: <1362750782-15174-1-git-send-email-ldewangan@nvidia.com> <1362750782-15174-5-git-send-email-ldewangan@nvidia.com> <513A2810.1070903@wwwdotorg.org> <513A2A6D.7080604@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <513A2A6D.7080604-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Peter De Schrijver List-Id: linux-tegra@vger.kernel.org On 03/08/2013 11:14 AM, Laxman Dewangan wrote: > On Friday 08 March 2013 11:34 PM, Stephen Warren wrote: >> On 03/08/2013 06:53 AM, Laxman Dewangan wrote: >>> NVIDIA's Tegra114 SoCs have the matrix keyboard controller which >>> supports 11x8 type of matrix. The number of rows and columns >>> are configurable. >> Earlier Tegra versions supported up to a 16x8 matrix. This feeds into >> the following defines in the driver: >> >> #define KBC_MAX_GPIO 24 >> #define KBC_MAX_ROW 16 >> #define KBC_MAX_COL 8 >> #define KBC_MAX_KEY (KBC_MAX_ROW * KBC_MAX_COL) >> >> Given Tegra114 supports /fewer/ pins and rows than earlier chips, I >> think that makes the HW technically incompatible, since GPIO IDs 19..23 >> are invalid in this HW but valid earlier. >> >> Now in practice I suppose that with a correct DT keyboard map for a >> Tegra114 device, those extra invalid GPIOs would never be referenced, so >> this is a little nit-picky, but I still feel we should fix this. > > Where do we fix this? In binding document? In the driver and .dtsi files; the rest of my message was describing how to fix this. From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Fri, 08 Mar 2013 11:42:27 -0700 Subject: [PATCH 4/5] ARM: DT: tegra114: add KBC controller DT entry In-Reply-To: <513A2A6D.7080604@nvidia.com> References: <1362750782-15174-1-git-send-email-ldewangan@nvidia.com> <1362750782-15174-5-git-send-email-ldewangan@nvidia.com> <513A2810.1070903@wwwdotorg.org> <513A2A6D.7080604@nvidia.com> Message-ID: <513A3113.10909@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/08/2013 11:14 AM, Laxman Dewangan wrote: > On Friday 08 March 2013 11:34 PM, Stephen Warren wrote: >> On 03/08/2013 06:53 AM, Laxman Dewangan wrote: >>> NVIDIA's Tegra114 SoCs have the matrix keyboard controller which >>> supports 11x8 type of matrix. The number of rows and columns >>> are configurable. >> Earlier Tegra versions supported up to a 16x8 matrix. This feeds into >> the following defines in the driver: >> >> #define KBC_MAX_GPIO 24 >> #define KBC_MAX_ROW 16 >> #define KBC_MAX_COL 8 >> #define KBC_MAX_KEY (KBC_MAX_ROW * KBC_MAX_COL) >> >> Given Tegra114 supports /fewer/ pins and rows than earlier chips, I >> think that makes the HW technically incompatible, since GPIO IDs 19..23 >> are invalid in this HW but valid earlier. >> >> Now in practice I suppose that with a correct DT keyboard map for a >> Tegra114 device, those extra invalid GPIOs would never be referenced, so >> this is a little nit-picky, but I still feel we should fix this. > > Where do we fix this? In binding document? In the driver and .dtsi files; the rest of my message was describing how to fix this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760079Ab3CHSmb (ORCPT ); Fri, 8 Mar 2013 13:42:31 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:51993 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759575Ab3CHSma (ORCPT ); Fri, 8 Mar 2013 13:42:30 -0500 Message-ID: <513A3113.10909@wwwdotorg.org> Date: Fri, 08 Mar 2013 11:42:27 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Laxman Dewangan CC: "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Peter De Schrijver Subject: Re: [PATCH 4/5] ARM: DT: tegra114: add KBC controller DT entry References: <1362750782-15174-1-git-send-email-ldewangan@nvidia.com> <1362750782-15174-5-git-send-email-ldewangan@nvidia.com> <513A2810.1070903@wwwdotorg.org> <513A2A6D.7080604@nvidia.com> In-Reply-To: <513A2A6D.7080604@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2013 11:14 AM, Laxman Dewangan wrote: > On Friday 08 March 2013 11:34 PM, Stephen Warren wrote: >> On 03/08/2013 06:53 AM, Laxman Dewangan wrote: >>> NVIDIA's Tegra114 SoCs have the matrix keyboard controller which >>> supports 11x8 type of matrix. The number of rows and columns >>> are configurable. >> Earlier Tegra versions supported up to a 16x8 matrix. This feeds into >> the following defines in the driver: >> >> #define KBC_MAX_GPIO 24 >> #define KBC_MAX_ROW 16 >> #define KBC_MAX_COL 8 >> #define KBC_MAX_KEY (KBC_MAX_ROW * KBC_MAX_COL) >> >> Given Tegra114 supports /fewer/ pins and rows than earlier chips, I >> think that makes the HW technically incompatible, since GPIO IDs 19..23 >> are invalid in this HW but valid earlier. >> >> Now in practice I suppose that with a correct DT keyboard map for a >> Tegra114 device, those extra invalid GPIOs would never be referenced, so >> this is a little nit-picky, but I still feel we should fix this. > > Where do we fix this? In binding document? In the driver and .dtsi files; the rest of my message was describing how to fix this.