From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEm2y-0006Qu-HE for qemu-devel@nongnu.org; Sun, 10 Mar 2013 15:36:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UEm2x-0003Qm-Fd for qemu-devel@nongnu.org; Sun, 10 Mar 2013 15:36:40 -0400 Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:43290 helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UEm2x-0003QK-3v for qemu-devel@nongnu.org; Sun, 10 Mar 2013 15:36:39 -0400 Message-ID: <513CE0C0.9060104@wiesinger.com> Date: Sun, 10 Mar 2013 20:36:32 +0100 From: Gerhard Wiesinger MIME-Version: 1.0 References: <513C7C61.8020102@wiesinger.com> <513CA3AB.1030608@wiesinger.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Compile error on FC17 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "qemu-devel@nongnu.org" On 10.03.2013 18:04, Peter Maydell wrote: > Oh, right. Tracing functions moved from trace.h to the files in the > trace/ subdirectory. This means that if you didn't do a make clean or > distclean before doing the git update then the new makefile knows > nothing about the old trace.h file and so won't delete it, but the > compiler may still pull it in anyhow. However this happened a long > time back which is why I didn't mention it as a possibility (it was > discussed on the list at the time as a number of people including me > ran into it). If you remove all the files: trace.c trace.h > trace.c-timestamp trace.h-timestamp this should resolve the problem. > This is an example of a longstanding problem we have, where the > makefile's dependency rules aren't able to cope with changes to the > project source file structure, and so clean, distclean and incremental > build sometimes breaks across a git update. I think this is pretty > intractable as a problem to solve; you can mitigate it by doing all > your builds in a build directory rather than in the source tree > itself, since then you can always just delete the whole build tree to > get a definite from-scratch build. rm -f trace.c trace.h libcacard/trace.c find . -name \*-timestamp -exec rm -f {} \; make distclean make clean ./configure --target-list=x86_64-softmmu # No files found find . -name \*-timestamp # No files found find . -name trace.c # Under git version control: # ./include/trace.h find . -name trace.h => Worked well But shouldn't "make distclean" do the job correctly (even with a changed directory structure, at least for some time)? Ciao, Gerhard