From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx201.postini.com [74.125.245.201]) by kanga.kvack.org (Postfix) with SMTP id 438346B0005 for ; Mon, 11 Mar 2013 01:21:17 -0400 (EDT) Message-ID: <513D689C.5030105@cn.fujitsu.com> Date: Mon, 11 Mar 2013 13:16:12 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v2, part1 29/29] mm,kexec: use common help functions to free reserved pages References: <1362896833-21104-1-git-send-email-jiang.liu@huawei.com> <1362896833-21104-30-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1362896833-21104-30-git-send-email-jiang.liu@huawei.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Jiang Liu Cc: Andrew Morton , David Rientjes , Jiang Liu , Wen Congyang , Maciej Rutecki , Chris Clayton , "Rafael J . Wysocki" , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Biederman =D3=DA 2013=C4=EA03=D4=C210=C8=D5 14:27, Jiang Liu =D0=B4=B5=C0: > Use common help functions to free reserved pages. >=20 > Signed-off-by: Jiang Liu > Cc: Eric Biederman Reviewed-by: Zhang Yanfei > --- > kernel/kexec.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) >=20 > diff --git a/kernel/kexec.c b/kernel/kexec.c > index bddd3d7..be95397 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -1118,12 +1118,8 @@ void =5F=5Fweak crash=5Ffree=5Freserved=5Fphys=5Fr= ange(unsigned long begin, > { > unsigned long addr; > =20 > - for (addr =3D begin; addr < end; addr +=3D PAGE=5FSIZE) { > - ClearPageReserved(pfn=5Fto=5Fpage(addr >> PAGE=5FSHIFT)); > - init=5Fpage=5Fcount(pfn=5Fto=5Fpage(addr >> PAGE=5FSHIFT)); > - free=5Fpage((unsigned long)=5F=5Fva(addr)); > - totalram=5Fpages++; > - } > + for (addr =3D begin; addr < end; addr +=3D PAGE=5FSIZE) > + free=5Freserved=5Fpage(pfn=5Fto=5Fpage(addr >> PAGE=5FSHIFT)); > } > =20 > int crash=5Fshrink=5Fmemory(unsigned long new=5Fsize) = -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775Ab3CKFVS (ORCPT ); Mon, 11 Mar 2013 01:21:18 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:28078 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750952Ab3CKFVR convert rfc822-to-8bit (ORCPT ); Mon, 11 Mar 2013 01:21:17 -0400 X-IronPort-AV: E=Sophos;i="4.84,820,1355068800"; d="scan'208";a="6848632" Message-ID: <513D689C.5030105@cn.fujitsu.com> Date: Mon, 11 Mar 2013 13:16:12 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 MIME-Version: 1.0 To: Jiang Liu CC: Andrew Morton , David Rientjes , Jiang Liu , Wen Congyang , Maciej Rutecki , Chris Clayton , "Rafael J . Wysocki" , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Eric Biederman Subject: Re: [PATCH v2, part1 29/29] mm,kexec: use common help functions to free reserved pages References: <1362896833-21104-1-git-send-email-jiang.liu@huawei.com> <1362896833-21104-30-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1362896833-21104-30-git-send-email-jiang.liu@huawei.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/03/11 13:16:33, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/03/11 13:20:00 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2013年03月10日 14:27, Jiang Liu 写道: > Use common help functions to free reserved pages. > > Signed-off-by: Jiang Liu > Cc: Eric Biederman Reviewed-by: Zhang Yanfei > --- > kernel/kexec.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/kernel/kexec.c b/kernel/kexec.c > index bddd3d7..be95397 100644 > --- a/kernel/kexec.c > +++ b/kernel/kexec.c > @@ -1118,12 +1118,8 @@ void __weak crash_free_reserved_phys_range(unsigned long begin, > { > unsigned long addr; > > - for (addr = begin; addr < end; addr += PAGE_SIZE) { > - ClearPageReserved(pfn_to_page(addr >> PAGE_SHIFT)); > - init_page_count(pfn_to_page(addr >> PAGE_SHIFT)); > - free_page((unsigned long)__va(addr)); > - totalram_pages++; > - } > + for (addr = begin; addr < end; addr += PAGE_SIZE) > + free_reserved_page(pfn_to_page(addr >> PAGE_SHIFT)); > } > > int crash_shrink_memory(unsigned long new_size)