From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
Subject: Re: [PATCH 6/8] memory: emif: fix timings initialization issue
Date: Mon, 11 Mar 2013 11:14:32 +0530 [thread overview]
Message-ID: <513D6F40.6080202@ti.com> (raw)
In-Reply-To: <1362978365-5593-7-git-send-email-lokeshvutla@ti.com>
$subject is too vague. What issue ?
Some thing like "Fix the incorrect 'size' parameter in memcpy' etc
On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote:
> From: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
>
> The issue was that only the first timings table was added to the
> emif platform data at the emif driver registration. All other
> timings tables was filled with zeros. Now all emif timings table
> are added to the platform data.
>
Luckily, most of the cases, first table has been re-used for
symmetric configuration.
> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> drivers/memory/emif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index 02a94fc..f75806a 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -1463,7 +1463,7 @@ static struct emif_data *__init_or_module get_device_details(
> if (pd->timings) {
> temp = devm_kzalloc(dev, size, GFP_KERNEL);
> if (temp) {
> - memcpy(temp, pd->timings, sizeof(*pd->timings));
> + memcpy(temp, pd->timings, size);
> pd->timings = temp;
> } else {
> dev_warn(dev, "%s:%d: allocation error\n", __func__,
>
Patch as such looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/8] memory: emif: fix timings initialization issue
Date: Mon, 11 Mar 2013 11:14:32 +0530 [thread overview]
Message-ID: <513D6F40.6080202@ti.com> (raw)
In-Reply-To: <1362978365-5593-7-git-send-email-lokeshvutla@ti.com>
$subject is too vague. What issue ?
Some thing like "Fix the incorrect 'size' parameter in memcpy' etc
On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote:
> From: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
>
> The issue was that only the first timings table was added to the
> emif platform data at the emif driver registration. All other
> timings tables was filled with zeros. Now all emif timings table
> are added to the platform data.
>
Luckily, most of the cases, first table has been re-used for
symmetric configuration.
> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> drivers/memory/emif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index 02a94fc..f75806a 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -1463,7 +1463,7 @@ static struct emif_data *__init_or_module get_device_details(
> if (pd->timings) {
> temp = devm_kzalloc(dev, size, GFP_KERNEL);
> if (temp) {
> - memcpy(temp, pd->timings, sizeof(*pd->timings));
> + memcpy(temp, pd->timings, size);
> pd->timings = temp;
> } else {
> dev_warn(dev, "%s:%d: allocation error\n", __func__,
>
Patch as such looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: <linux-kernel@vger.kernel.org>, <gregkh@linuxfoundation.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
Subject: Re: [PATCH 6/8] memory: emif: fix timings initialization issue
Date: Mon, 11 Mar 2013 11:14:32 +0530 [thread overview]
Message-ID: <513D6F40.6080202@ti.com> (raw)
In-Reply-To: <1362978365-5593-7-git-send-email-lokeshvutla@ti.com>
$subject is too vague. What issue ?
Some thing like "Fix the incorrect 'size' parameter in memcpy' etc
On Monday 11 March 2013 10:36 AM, Lokesh Vutla wrote:
> From: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
>
> The issue was that only the first timings table was added to the
> emif platform data at the emif driver registration. All other
> timings tables was filled with zeros. Now all emif timings table
> are added to the platform data.
>
Luckily, most of the cases, first table has been re-used for
symmetric configuration.
> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> drivers/memory/emif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c
> index 02a94fc..f75806a 100644
> --- a/drivers/memory/emif.c
> +++ b/drivers/memory/emif.c
> @@ -1463,7 +1463,7 @@ static struct emif_data *__init_or_module get_device_details(
> if (pd->timings) {
> temp = devm_kzalloc(dev, size, GFP_KERNEL);
> if (temp) {
> - memcpy(temp, pd->timings, sizeof(*pd->timings));
> + memcpy(temp, pd->timings, size);
> pd->timings = temp;
> } else {
> dev_warn(dev, "%s:%d: allocation error\n", __func__,
>
Patch as such looks good to me.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2013-03-11 5:44 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 5:05 [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver Lokesh Vutla
2013-03-11 5:05 ` Lokesh Vutla
2013-03-11 5:05 ` Lokesh Vutla
2013-03-11 5:05 ` [PATCH 1/8] memory: emif: Correct the lpmode timeout calculation Lokesh Vutla
2013-03-11 5:05 ` Lokesh Vutla
2013-03-11 5:05 ` Lokesh Vutla
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:05 ` [PATCH 2/8] memory: emif: setup LP settings on freq update Lokesh Vutla
2013-03-11 5:05 ` Lokesh Vutla
2013-03-11 5:05 ` Lokesh Vutla
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:34 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 3/8] memory: emif: handle overflow for timing for LP mode Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:35 ` Santosh Shilimkar
2013-03-11 5:35 ` Santosh Shilimkar
2013-03-11 5:35 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 4/8] memory: emif: Handle devices which are not rated for >85C Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:38 ` Santosh Shilimkar
2013-03-11 5:38 ` Santosh Shilimkar
2013-03-11 5:38 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 5/8] memory: emif: use restart if power_off not present when out of spec Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:39 ` Santosh Shilimkar
2013-03-11 5:39 ` Santosh Shilimkar
2013-03-11 5:39 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 6/8] memory: emif: fix timings initialization issue Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:44 ` Santosh Shilimkar [this message]
2013-03-11 5:44 ` Santosh Shilimkar
2013-03-11 5:44 ` Santosh Shilimkar
2013-03-11 5:06 ` [PATCH 7/8] memory: emif: errata i743: Prohibit usage of Power-Down mode Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:50 ` Santosh Shilimkar
2013-03-11 5:50 ` Santosh Shilimkar
2013-03-11 5:50 ` Santosh Shilimkar
2013-03-11 11:10 ` Lokesh Vutla
2013-03-11 11:10 ` Lokesh Vutla
2013-03-11 11:10 ` Lokesh Vutla
2013-03-11 5:06 ` [PATCH 8/8] memory: emif: Load the correct custom config values from dt Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:06 ` Lokesh Vutla
2013-03-11 5:51 ` Santosh Shilimkar
2013-03-11 5:51 ` Santosh Shilimkar
2013-03-11 5:51 ` Santosh Shilimkar
2013-03-15 18:08 ` [PATCH 0/8] memory: emif: miscellaneous bug fixes for EMIF driver Greg KH
2013-03-15 18:08 ` Greg KH
2013-03-16 6:13 ` Lokesh Vutla
2013-03-16 6:13 ` Lokesh Vutla
2013-03-16 6:13 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513D6F40.6080202@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=oleksandr.dmytryshyn@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.