From: Archit Taneja <archit@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 20/20] OMAPDSS: Taal: remove rotate & mirror support
Date: Mon, 11 Mar 2013 06:33:59 +0000 [thread overview]
Message-ID: <513D7807.2010509@ti.com> (raw)
In-Reply-To: <1362743515-10152-21-git-send-email-tomi.valkeinen@ti.com>
Hi,
On Friday 08 March 2013 05:21 PM, Tomi Valkeinen wrote:
> Taal panel driver has support to set rotation and mirroring. However,
> these features cannot be used without causing tearing, and are never
> used. The code is just extra bloat, so let's remove it.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
<snip>
> static ssize_t taal_num_errors_show(struct device *dev,
> @@ -1025,10 +973,6 @@ static int taal_power_on(struct omap_dss_device *dssdev)
> if (r)
> goto err;
>
> - r = taal_set_addr_mode(td, td->rotate, td->mirror);
> - if (r)
> - goto err;
> -
I'm curious if we need to set the address mode(to the default value) at
least once. It may not be a requirement for Taal, but if that's the
case, why did we have a set_addr_mode() call in taal_power_on() in the
first place? Is it because we can prepare rotation and mirroring before
we enable the panel?
Archit
WARNING: multiple messages have this Message-ID (diff)
From: Archit Taneja <archit@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 20/20] OMAPDSS: Taal: remove rotate & mirror support
Date: Mon, 11 Mar 2013 11:51:59 +0530 [thread overview]
Message-ID: <513D7807.2010509@ti.com> (raw)
In-Reply-To: <1362743515-10152-21-git-send-email-tomi.valkeinen@ti.com>
Hi,
On Friday 08 March 2013 05:21 PM, Tomi Valkeinen wrote:
> Taal panel driver has support to set rotation and mirroring. However,
> these features cannot be used without causing tearing, and are never
> used. The code is just extra bloat, so let's remove it.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
<snip>
> static ssize_t taal_num_errors_show(struct device *dev,
> @@ -1025,10 +973,6 @@ static int taal_power_on(struct omap_dss_device *dssdev)
> if (r)
> goto err;
>
> - r = taal_set_addr_mode(td, td->rotate, td->mirror);
> - if (r)
> - goto err;
> -
I'm curious if we need to set the address mode(to the default value) at
least once. It may not be a requirement for Taal, but if that's the
case, why did we have a set_addr_mode() call in taal_power_on() in the
first place? Is it because we can prepare rotation and mirroring before
we enable the panel?
Archit
next prev parent reply other threads:[~2013-03-11 6:33 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 11:51 [PATCH 00/20] OMAPDSS: misc improvements Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 01/20] OMAPDSS: DSI: remove DSI & DISPC clk divisors from dssdev Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 02/20] OMAPDSS: HDMI: remove HDMI " Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 03/20] OMAPDSS: DPI: remove omap_dss_device uses Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 04/20] OMAPDSS: DSI: " Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 05/20] OMAPDSS: Taal: remove multi-panel support Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 06/20] OMAPDSS: APPLY: remove dssdev from dss_mgr_wait_for_vsync Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 07/20] OMAPDSS: add missing export for omap_dss_get_output() Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 08/20] OMAPDSS: HDMI: init output earlier Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 09/20] OMAPDSS: add output->name Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 10/20] OMAPDSS: Resolve channels for outputs Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-11 5:35 ` Archit Taneja
2013-03-11 5:47 ` Archit Taneja
2013-03-11 11:02 ` Tomi Valkeinen
2013-03-11 11:02 ` Tomi Valkeinen
2013-03-11 12:05 ` Tomi Valkeinen
2013-03-11 12:05 ` Tomi Valkeinen
2013-03-11 12:19 ` Archit Taneja
2013-03-11 12:31 ` Archit Taneja
2013-03-11 5:53 ` Archit Taneja
2013-03-11 5:54 ` Archit Taneja
2013-03-11 11:54 ` Tomi Valkeinen
2013-03-11 11:54 ` Tomi Valkeinen
2013-03-11 12:01 ` Tomi Valkeinen
2013-03-11 12:01 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 11/20] OMAPDSS: add output->recommended_channel Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 12/20] OMAPDSS: DPI: use output->recommended_channel Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 13/20] OMAPFB: " Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 14/20] OMAPDSS: remove dssdev->channel assignments Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-11 6:24 ` Archit Taneja
2013-03-11 6:36 ` Archit Taneja
2013-03-08 11:51 ` [PATCH 15/20] OMAP: dss-common.c: remove uses of dss channel (LATER) Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 16/20] OMAPDSS: omapdss.h: remove channel field from omap_dss_device (LATER) Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 17/20] OMAPDSS: add pdata->default_display_name Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 18/20] OMAPDSS: DSI: delay dispc initialization Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-11 6:05 ` Archit Taneja
2013-03-11 6:17 ` Archit Taneja
2013-03-08 11:51 ` [PATCH 19/20] OMAPDSS: DSI: fix DSI channel source initialization Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-11 6:10 ` Archit Taneja
2013-03-11 6:22 ` Archit Taneja
2013-03-11 7:02 ` Tomi Valkeinen
2013-03-11 7:02 ` Tomi Valkeinen
2013-03-11 8:15 ` Archit Taneja
2013-03-11 8:27 ` Archit Taneja
2013-03-11 8:25 ` Tomi Valkeinen
2013-03-11 8:25 ` Tomi Valkeinen
2013-03-08 11:51 ` [PATCH 20/20] OMAPDSS: Taal: remove rotate & mirror support Tomi Valkeinen
2013-03-08 11:51 ` Tomi Valkeinen
2013-03-11 6:21 ` Archit Taneja [this message]
2013-03-11 6:33 ` Archit Taneja
2013-03-11 6:51 ` Tomi Valkeinen
2013-03-11 6:51 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513D7807.2010509@ti.com \
--to=archit@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.