From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Chuansheng Liu <chuansheng.liu@intel.com>
Cc: lenb@kernel.org, len.brown@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3 V2] intel_idle: Removing the redundant calculating for dev->state_count
Date: Mon, 11 Mar 2013 10:08:51 +0100 [thread overview]
Message-ID: <513D9F23.5050705@linaro.org> (raw)
In-Reply-To: <1362998657.31506.52.camel@cliu38-desktop-build>
On 03/11/2013 11:44 AM, Chuansheng Liu wrote:
>
> In function intel_idle_cpu_init() and intel_idle_cpuidle_driver_init(),
> they are having the same for(;;) loop to count the ->state_count.
>
> Although intel_idle_cpu_init() can be called at runtime CPU HOTPLUG case,
> but max_cstate can not be changed at runtime.
>
> So the dev->state_count should be == drv->state_count, in the function
> cpuidle_register_device() has done the initialization.
>
> Here we can clean up these pieces of code.
>
> Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
> ---
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-03-11 9:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 16:42 [PATCH] intel_idle: set the state_tables array into __initdata to save mem Chuansheng Liu
2013-03-07 9:49 ` Daniel Lezcano
2013-03-08 0:44 ` Liu, Chuansheng
2013-03-08 0:44 ` Liu, Chuansheng
2013-03-08 15:02 ` [PATCH 0/3] " Chuansheng Liu
2013-03-08 15:03 ` [PATCH 1/3] intel_idle: changing the continue to break in intel_idle_cpu_init() Chuansheng Liu
2013-03-09 3:01 ` Daniel Lezcano
2013-03-08 15:04 ` [PATCH 2/3] intel_idle: Removing the redundant calculating for dev->state_count Chuansheng Liu
2013-03-09 3:00 ` Daniel Lezcano
2013-03-11 1:29 ` Liu, Chuansheng
2013-03-11 1:29 ` Liu, Chuansheng
2013-03-11 10:44 ` [PATCH 2/3 V2] " Chuansheng Liu
2013-03-11 9:08 ` Daniel Lezcano [this message]
2013-03-08 15:06 ` [PATCH 3/3] intel_idle: set the state_tables array as __initdata to save mem Chuansheng Liu
2013-03-09 3:01 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513D9F23.5050705@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=chuansheng.liu@intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.