From: Jiri Horky <jiri.horky@cesnet.cz>
To: Alex Pyrgiotis <apyrgio@grnet.gr>
Cc: fio@vger.kernel.org, synnefo-devel@googlegroups.com
Subject: Re: [PATCH 2/2] Add a simple test for LFSR generator
Date: Mon, 11 Mar 2013 16:51:33 +0100 [thread overview]
Message-ID: <513DFD85.2080107@cesnet.cz> (raw)
In-Reply-To: <1362746224-5162-3-git-send-email-apyrgio@grnet.gr>
[-- Attachment #1: Type: text/plain, Size: 529 bytes --]
Hi Alex,
I just used your implementation in a different project as well, thanks
for it :) One small correction, I think that the last line of:
On 03/08/2013 01:37 PM, Alex Pyrgiotis wrote:
> + /* Check if all expected numbers within range have been calculated */
> + r = 0;
> + if (verify) {
> + fprintf(stderr, "Verifying results... ");
> + for (i = 0; i < numbers; i++) {
> + if (*(uint8_t *)(v + 1) != 1) {
should be:
if (*(uint8_t *)(v + i) != 1) {
(not +1, but +i).
Regards
Jiri Horky
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 3376 bytes --]
next prev parent reply other threads:[~2013-03-11 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 12:37 [PATCH 0/2] Proposed LFSR implementation Alex Pyrgiotis
2013-03-08 12:37 ` [PATCH 1/2] Improve " Alex Pyrgiotis
2013-03-08 12:37 ` [PATCH 2/2] Add a simple test for LFSR generator Alex Pyrgiotis
2013-03-11 15:51 ` Jiri Horky [this message]
2013-03-12 6:45 ` Alex Pyrgiotis
2013-03-11 11:27 ` [PATCH 0/2] Proposed LFSR implementation Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2013-03-08 18:30 Alex Pyrgiotis
2013-03-08 18:30 ` [PATCH 2/2] Add a simple test for LFSR generator Alex Pyrgiotis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DFD85.2080107@cesnet.cz \
--to=jiri.horky@cesnet.cz \
--cc=apyrgio@grnet.gr \
--cc=fio@vger.kernel.org \
--cc=synnefo-devel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.