From: Stephen Warren <swarren@wwwdotorg.org>
To: Kevin Liu <keyuan.liu@gmail.com>
Cc: Kevin Liu <kliu5@marvell.com>,
linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Aaron Lu <aaron.lu@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Wei WANG <wei_wang@realsil.com.cn>,
Fabio Estevam <fabio.estevam@freescale.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Philip Rakity <prakity@nvidia.com>,
Shawn Guo <shawn.guo@linaro.org>,
Johan Rudholm <johan.rudholm@stericsson.com>,
Girish K S <girish.shivananjappa@linaro.org>,
Haijun Zhang <Haijun.Zhang@freescale.com>,
Zhangfei Gao <zhangfei.gao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Chao Xie <cxie4@marvell.com>
Subject: Re: [PATCH] mmc: sdhci-pltfm: add calling mmc_of_parse in sdhci_pltfm_register
Date: Mon, 11 Mar 2013 09:53:28 -0600 [thread overview]
Message-ID: <513DFDF8.5090604@wwwdotorg.org> (raw)
In-Reply-To: <CADz5_gJXb85MPcrXer-13rJB7VYG=fuf28NpPVBif9tHUmAG-g@mail.gmail.com>
On 03/08/2013 09:27 PM, Kevin Liu wrote:
> 2013/3/9 Stephen Warren <swarren@wwwdotorg.org>:
>> On 03/07/2013 09:52 PM, Kevin Liu wrote:
>>> commit 6c56e7a0 provide a function mmc_of_parse for standard MMC
>>> device-tree binding parser centrally. So just call it with
>>> sdhci_get_of_property together in sdhci_pltfm_register.
>>
>> BTW, this patch seems to do two unrelated things; firstly it changes the
>> indentation level throughout sdhci_get_of_property(), and secondly makes
>> the change described in the commit description.
>
> That's true. I originally want to do the first thing incidentally :-)
> So do you want to split this patch into two?
It's Chris's call, but I think it'd be more usual to make this two
separate patches.
next prev parent reply other threads:[~2013-03-11 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 4:52 [PATCH] mmc: sdhci-pltfm: add calling mmc_of_parse in sdhci_pltfm_register Kevin Liu
2013-03-08 20:18 ` Stephen Warren
2013-03-09 4:27 ` Kevin Liu
2013-03-11 15:53 ` Stephen Warren [this message]
2013-03-12 2:03 ` Kevin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DFDF8.5090604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Haijun.Zhang@freescale.com \
--cc=aaron.lu@intel.com \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=cxie4@marvell.com \
--cc=fabio.estevam@freescale.com \
--cc=g.liakhovetski@gmx.de \
--cc=girish.shivananjappa@linaro.org \
--cc=haojian.zhuang@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=johan.rudholm@stericsson.com \
--cc=keyuan.liu@gmail.com \
--cc=kliu5@marvell.com \
--cc=linux-mmc@vger.kernel.org \
--cc=prakity@nvidia.com \
--cc=shawn.guo@linaro.org \
--cc=sthumma@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
--cc=zhangfei.gao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.