From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V2 0/5] rtc: tegra: cleanups to remove warning/code lines Date: Mon, 11 Mar 2013 11:19:23 -0600 Message-ID: <513E121B.60401@wwwdotorg.org> References: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1362991468-30226-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/11/2013 02:44 AM, Laxman Dewangan wrote: > This patch series does the cleanups in the rtc driver as follows: > - Protect suspend/resume with CONFIG_PM_SLEEP. > - Use dev_pm_ops in place of legacy way for suspend/resume. > - Properly reflect teh irq name when doing cat /proc/interrupts. > - Use module_platform_probe() to remove boilerplate code. > - use devm_rtc_device_register. Assuming there's a good explanation for my question re: patch 3/5, then the series, Reviewed-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753913Ab3CKRT1 (ORCPT ); Mon, 11 Mar 2013 13:19:27 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:59165 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063Ab3CKRT0 (ORCPT ); Mon, 11 Mar 2013 13:19:26 -0400 Message-ID: <513E121B.60401@wwwdotorg.org> Date: Mon, 11 Mar 2013 11:19:23 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Laxman Dewangan CC: akpm@linux-foundation.org, a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, thierry.reding@avionic-design.de Subject: Re: [PATCH V2 0/5] rtc: tegra: cleanups to remove warning/code lines References: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2013 02:44 AM, Laxman Dewangan wrote: > This patch series does the cleanups in the rtc driver as follows: > - Protect suspend/resume with CONFIG_PM_SLEEP. > - Use dev_pm_ops in place of legacy way for suspend/resume. > - Properly reflect teh irq name when doing cat /proc/interrupts. > - Use module_platform_probe() to remove boilerplate code. > - use devm_rtc_device_register. Assuming there's a good explanation for my question re: patch 3/5, then the series, Reviewed-by: Stephen Warren