All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] DOS_PBR block type is also valid dos block type.
Date: Mon, 11 Mar 2013 11:28:05 -0600	[thread overview]
Message-ID: <513E1425.2030604@wwwdotorg.org> (raw)
In-Reply-To: <1362995768-30954-1-git-send-email-sonic.adi@gmail.com>

On 03/11/2013 03:56 AM, sonic.adi at gmail.com wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
> 
> - Should return 0 for both DOS_MBR and DOS_PBR block types in test_part_dos().

What problem does this solve?

I don't believe this change is correct. The purpose of test_part_dos()
is to determine whether a block device contains an MS-DOS partition table.

Such a partition table is present in an MBR, but not a PBR. A PBR
contains a *FAT file-system, and does not include a partition table.

  reply	other threads:[~2013-03-11 17:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-11  9:56 [U-Boot] [PATCH v1] DOS_PBR block type is also valid dos block type sonic.adi at gmail.com
2013-03-11 17:28 ` Stephen Warren [this message]
2013-03-12  2:59   ` Sonic Zhang
2013-03-13 17:11     ` Stephen Warren
2013-03-14  2:51       ` Sonic Zhang
2013-03-14  4:36         ` Stephen Warren
2013-03-14  7:31           ` Sonic Zhang
2013-03-14 17:53             ` Stephen Warren
2013-03-15  5:10     ` Stephen Warren
2013-03-15  6:36       ` Sonic Zhang
2013-03-15 13:14         ` Tom Rini
2013-03-15 17:09         ` Stephen Warren
2013-03-15 17:29           ` Tom Rini
2013-03-15 12:46       ` Tom Rini
2013-03-15 17:07         ` Stephen Warren
     [not found]   ` <CAJxxZ0Pk2CtS0FuYJyZDqq3NyUZEnCjnjsksx7buv8RiLf+3vQ@mail.gmail.com>
     [not found]     ` <513E9C79.2000708@wwwdotorg.org>
2013-03-13  2:58       ` Sonic Zhang
2013-03-13 16:51         ` Stephen Warren
2013-03-13 17:01           ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513E1425.2030604@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.