Re: [PATCH 0/8] libceph: implement cursor for outgoing data items

[Josh Durgin <josh.durgin@inktank.com>]

On 03/10/2013 12:06 PM, Alex Elder wrote:
> This series makes the four distinct data items in a message (the
> pages array, the pagelist, the bio, and the trail) take a generic
> form, and then arranges for them all to be handled using a common
> set of cursor routines that determine what data needs to be sent
> next for a message.  There is more consolidation of this code
> coming, but for now I'm leaving this series at 8 patches, which
> includes the definition of cursor code for the three types of
> data item.
>
> 					-Alex
>
> [PATCH 1/8] libceph: define ceph_msg_has_*() data macros
> [PATCH 2/8] libceph: be explicit about message data representation
> [PATCH 3/8] libceph: abstract message data
> [PATCH 4/8] libceph: start defining message data cursor
> [PATCH 5/8] libceph: prepare for other message data item types
> [PATCH 6/8] libceph: use data cursor for message pagelist
> [PATCH 7/8] libceph: implement bio message data item cursor
> [PATCH 8/8] libceph: implement pages array cursor

These look good. I assume you're going to remove the single character
struct members in a later series.

Reviewed-by: Josh Durgin <josh.durgin@inktank.com>