From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32842)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UFKps-0001Xe-Lk
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:45:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UFKpo-0006wr-1O
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:45:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5888)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UFKpn-0006wP-Nt
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 04:45:23 -0400
Message-ID: <513EEB1B.1000705@redhat.com>
Date: Tue, 12 Mar 2013 09:45:15 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1362624800-10682-1-git-send-email-qemulist@gmail.com>
	<1362624800-10682-6-git-send-email-qemulist@gmail.com>
In-Reply-To: <1362624800-10682-6-git-send-email-qemulist@gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 5/5] net: make netclient re-entrant with
	refcnt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, mdroth <mdroth@linux.vnet.ibm.com>

Il 07/03/2013 03:53, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> 
> With refcnt, NetClientState's caller can run agaist reclaimer.
> 
> Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
> ---
>  hw/qdev-properties-system.c |   14 +++++++++++++
>  include/net/net.h           |    3 ++
>  net/hub.c                   |    3 ++
>  net/net.c                   |   46 ++++++++++++++++++++++++++++++++++++++++--
>  net/slirp.c                 |    3 +-
>  5 files changed, 65 insertions(+), 4 deletions(-)

The patch makes sense, but the commit message does not yet.

Please add documentation to include/net/net.h, specifying the functions
that add a reference to the returned NetClientState.

Paolo