diff for duplicates of <513F1B76.2060603@gmail.com> diff --git a/a/1.txt b/N1/1.txt index a199160..80b9817 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -21,12 +21,12 @@ On 03/11/2013 09:31 AM, Neil Horman wrote: >>>> sctp_association *asoc, >>>> transports) { >>>> ->>>> if (transport = active) +>>>> if (transport == active) >>>> - break; >>>> + continue; >>>> list_for_each_entry(chunk, &transport->transmitted, >>>> transmitted_list) { ->>>> if (key = chunk->subh.data_hdr->tsn) { +>>>> if (key == chunk->subh.data_hdr->tsn) { >>>> -- >>>> 1.7.0.2 >>>> @@ -62,7 +62,7 @@ On 03/11/2013 09:31 AM, Neil Horman wrote: > I understand what you're doing, and I agree that the fix is functional (Hence > my "This works" statement in my last note). What I'm suggesting is that, since > you're messing about in that code anyway that you clean it up while your at it, -> so that we don't need to have the if (transport = active) check at all. We +> so that we don't need to have the if (transport == active) check at all. We > trade in some extra work in a non-critical path (sctp_assoc_set_primary), for > the removal of an extra for loop operation and a conditional check in a much > hotter path. Something like this (completely untested), is what I was thinking @@ -121,7 +121,7 @@ The optimization here may not work at all under those circumstances. > - list_for_each_entry(chunk, &active->transmitted, > - transmitted_list) { > - -> - if (key = chunk->subh.data_hdr->tsn) { +> - if (key == chunk->subh.data_hdr->tsn) { > - match = active; > - goto out; > - } @@ -131,9 +131,9 @@ The optimization here may not work at all under those circumstances. > list_for_each_entry(transport, &asoc->peer.transport_addr_list, > transports) { > -> - if (transport = active) +> - if (transport == active) > - break; > list_for_each_entry(chunk, &transport->transmitted, > transmitted_list) { -> if (key = chunk->subh.data_hdr->tsn) { +> if (key == chunk->subh.data_hdr->tsn) { > diff --git a/a/content_digest b/N1/content_digest index 1084b4d..b1145d2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,8 +3,8 @@ "ref\0CA+=dFzjyd4av9D1TmrvguRXv-V7JnGWYJcN=ZEDu8Qhz2s+U7Q@mail.gmail.com\0" "ref\020130311133121.GD12682@hmsreliant.think-freely.org\0" "From\0Vlad Yasevich <vyasevich@gmail.com>\0" - "Subject\0Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched trans\0" - "Date\0Tue, 12 Mar 2013 12:11:34 +0000\0" + "Subject\0Re: [PATCH] sctp: don't break the loop while meeting the active_path so as to find the matched transport\0" + "Date\0Tue, 12 Mar 2013 08:11:34 -0400\0" "To\0Neil Horman <nhorman@tuxdriver.com>\0" "Cc\0Xufeng Zhang <xufengzhang.main@gmail.com>" Xufeng Zhang <xufeng.zhang@windriver.com> @@ -37,12 +37,12 @@ ">>>> sctp_association *asoc,\n" ">>>> \t\t\ttransports) {\n" ">>>>\n" - ">>>> \t\tif (transport = active)\n" + ">>>> \t\tif (transport == active)\n" ">>>> -\t\t\tbreak;\n" ">>>> +\t\t\tcontinue;\n" ">>>> \t\tlist_for_each_entry(chunk, &transport->transmitted,\n" ">>>> \t\t\t\ttransmitted_list) {\n" - ">>>> \t\t\tif (key = chunk->subh.data_hdr->tsn) {\n" + ">>>> \t\t\tif (key == chunk->subh.data_hdr->tsn) {\n" ">>>> --\n" ">>>> 1.7.0.2\n" ">>>>\n" @@ -78,7 +78,7 @@ "> I understand what you're doing, and I agree that the fix is functional (Hence\n" "> my \"This works\" statement in my last note). What I'm suggesting is that, since\n" "> you're messing about in that code anyway that you clean it up while your at it,\n" - "> so that we don't need to have the if (transport = active) check at all. We\n" + "> so that we don't need to have the if (transport == active) check at all. We\n" "> trade in some extra work in a non-critical path (sctp_assoc_set_primary), for\n" "> the removal of an extra for loop operation and a conditional check in a much\n" "> hotter path. Something like this (completely untested), is what I was thinking\n" @@ -137,7 +137,7 @@ "> -\tlist_for_each_entry(chunk, &active->transmitted,\n" "> -\t\t\ttransmitted_list) {\n" "> -\n" - "> -\t\tif (key = chunk->subh.data_hdr->tsn) {\n" + "> -\t\tif (key == chunk->subh.data_hdr->tsn) {\n" "> -\t\t\tmatch = active;\n" "> -\t\t\tgoto out;\n" "> -\t\t}\n" @@ -147,11 +147,11 @@ "> \tlist_for_each_entry(transport, &asoc->peer.transport_addr_list,\n" "> \t\t\ttransports) {\n" ">\n" - "> -\t\tif (transport = active)\n" + "> -\t\tif (transport == active)\n" "> -\t\t\tbreak;\n" "> \t\tlist_for_each_entry(chunk, &transport->transmitted,\n" "> \t\t\t\ttransmitted_list) {\n" - "> \t\t\tif (key = chunk->subh.data_hdr->tsn) {\n" + "> \t\t\tif (key == chunk->subh.data_hdr->tsn) {\n" > -6ed86643bbb1aa1294257a9827cbb052b643bad91a160d4608a551130ec84ea9 +30d239dadad966f9feada93034d10154e8986bcf568c5c2765866cbb65f12cba
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.