All of lore.kernel.org
 help / color / mirror / Atom feed
From: kishon <kishon@ti.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
	Felipe Balbi <balbi@ti.com>, NeilBrown <neilb@suse.de>
Subject: Re: [PATCH 2/7] usb: otg: twl4030-usb: ignore duplicate events
Date: Tue, 12 Mar 2013 19:02:33 +0530	[thread overview]
Message-ID: <513F2E71.7020502@ti.com> (raw)
In-Reply-To: <1362877681-8102-3-git-send-email-notasas@gmail.com>

Hi,

On Sunday 10 March 2013 06:37 AM, Grazvydas Ignotas wrote:
> In some rare cases we may get multiple interrupts that will generate
> duplicate omap_musb_mailbox() calls. This is a problem because each
> VBUS/ID event generates runtime_pm call in OMAP glue code, causing
> unbalanced gets or puts and breaking PM.

Did you actually observed multiple interrupts? Actually we thought 
debouncing should be handled in hardware.
>
> The same goes for initial state, glue already defaults to "no cable"
> state, so only bother it if we have VBUS or ID.
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>

Thanks
Kishon

  reply	other threads:[~2013-03-12 13:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  1:07 [PATCH 0/7] usb: otg: twl4030-usb fixes Grazvydas Ignotas
2013-03-10  1:07 ` [PATCH 1/7] usb: otg: twl4030-usb: don't enable PHY during init Grazvydas Ignotas
2013-03-10  1:07 ` [PATCH 2/7] usb: otg: twl4030-usb: ignore duplicate events Grazvydas Ignotas
2013-03-12 13:32   ` kishon [this message]
2013-03-12 14:55     ` Grazvydas Ignotas
2013-03-10  1:07 ` [PATCH 3/7] usb: otg: twl4030-usb: don't switch the phy on/off needlessly Grazvydas Ignotas
2013-03-10  1:07 ` [PATCH 4/7] usb: otg: twl4030-usb: poll for ID disconnect Grazvydas Ignotas
     [not found]   ` <1362877681-8102-5-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-10 11:03     ` Michael Trimarchi
2013-03-10 14:49       ` Grazvydas Ignotas
2013-03-10  1:07 ` [PATCH 5/7] usb: otg: twl4030-usb: check if vbus is driven by twl itself Grazvydas Ignotas
2013-03-10  1:08 ` [PATCH 6/7] usb: musb: omap2430: turn off vbus on cable disconnect Grazvydas Ignotas
2013-03-12 13:37   ` kishon
     [not found]     ` <513F2F7C.3040803-l0cyMroinI0@public.gmane.org>
2013-03-12 15:03       ` Grazvydas Ignotas
     [not found] ` <1362877681-8102-1-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-10  1:08   ` [PATCH 7/7] usb: musb: gadget: use platform callback to enable vbus Grazvydas Ignotas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513F2E71.7020502@ti.com \
    --to=kishon@ti.com \
    --cc=balbi@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=notasas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.