Re: [PATCH] Add vendor quirk for SIMCOM

[Viallard Anthony <viallard@syscom-instruments.com>]

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On 12. 03. 13 15:40, r.r.zaripov(a)gmail.com wrote:
> From: Renat Zaripov<r.r.zaripov@gmail.com>
>
> ---
>   drivers/atmodem/gprs-context.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-context.c
> index 3694c27..0fb63c4 100644
> --- a/drivers/atmodem/gprs-context.c
> +++ b/drivers/atmodem/gprs-context.c
> @@ -208,7 +208,11 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *result, gpointer user_data)
>   		return;
>   	}
>
> -	sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +	if (gcd->vendor == OFONO_VENDOR_SIMCOM)
> +		strcpy(buf, "ATD*99#\0");
> +	else
> +		sprintf(buf, "AT+CGDATA=\"PPP\",%u", gcd->active_context);
> +
>   	if (g_at_chat_send(gcd->chat, buf, none_prefix,
>   				at_cgdata_cb, gc, NULL)>  0)
>   		return;

Hello Renat,

I watched the AT commands set for my SIM5216 and I found AT+CGDATA. 
There isn't this command for sim900 ?

And, I saw "ATD*99#" cryptic command was already used in 
gatchat/gsmdial.c if bluetooth is enabled.

Maybe, it's a specific command for your purpose ? I mean, do you need 
this command to "establish communication between the TE and the network 
using one or more Packet Domain PDP types." ? If it's the case, the 
quirk is only for your device and so, it's not a vendor quirk.
	
Otherwise, why this \0 after ATD*99# ? :)

Regards,
Anthony.