Re: [PATCH v0 13/15] handsfree-audio: Return InProgress on Connect

[Frederic Danis <frederic.danis@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1117 bytes --]

Hello Claudio,

On 12/03/2013 13:42, Claudio Takahasi wrote:
> This patch returns "Operation already in progress" if there is a
> pending Handsfree Audio Card "Connect" method call pending.
> ---
>   src/handsfree-audio.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/handsfree-audio.c b/src/handsfree-audio.c
> index 8950347..805f3b6 100644
> --- a/src/handsfree-audio.c
> +++ b/src/handsfree-audio.c
> @@ -285,6 +285,9 @@ static DBusMessage *card_connect(DBusConnection *conn,
>   	if (agent == NULL)
>   		return __ofono_error_not_available(msg);
>
> +	if (card->msg)
> +		return __ofono_error_busy(msg);
> +
>   	sk = driver->audio_connect(card->remote, card->local);
>   	if (sk < 0)
>   		return __ofono_error_failed(msg);
>

Shouldn't you also test if there is already a SCO connection (sco_watch) ?
I think that only one SCO link can be connected at a time for a 
Handsfree Audio Card.

Regards

Fred

-- 
Frederic Danis                            Open Source Technology Center
frederic.danis(a)intel.com                              Intel Corporation