All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@dlhnet.de>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Orit Wasserman <owasserm@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>
Subject: [Qemu-devel] [RFC][PATCH 8/9] migration: do not sent zero_pages in bulk stage
Date: Tue, 12 Mar 2013 16:54:14 +0100	[thread overview]
Message-ID: <513F4FA6.6000701@dlhnet.de> (raw)

if the dup_page is a zero_page do not send it at all.
the memory at the destination reads as zero anyway.

Signed-off-by: Peter Lieven <pl@kamp.de>
---
  arch_init.c |    6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch_init.c b/arch_init.c
index 04c82e4..abd54a7 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -447,9 +447,11 @@ static int ram_save_block(QEMUFile *f, bool last_stage)
              bytes_sent = -1;
              if (ram_bulk_stage && is_dup_page(p)) {
                  acct_info.dup_pages++;
-                bytes_sent = save_block_hdr(f, block, offset, cont,
+                if (p[0]) {
+                    bytes_sent = save_block_hdr(f, block, offset, cont,
                                              RAM_SAVE_FLAG_COMPRESS);
-                qemu_put_byte(f, *p);
+                    qemu_put_byte(f, *p);
+                }
                  bytes_sent += 1;
              } else if (!ram_bulk_stage && migrate_use_xbzrle()) {
                  current_addr = block->offset + offset;
-- 
1.7.9.5

             reply	other threads:[~2013-03-12 15:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 15:54 Peter Lieven [this message]
2013-03-12 20:26 ` [Qemu-devel] [RFC][PATCH 8/9] migration: do not sent zero_pages in bulk stage Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513F4FA6.6000701@dlhnet.de \
    --to=pl@dlhnet.de \
    --cc=kwolf@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.