Re: [Qemu-devel] [RFC][PATCH 7/9] bitops: use vector algorithm to optimize find_next_bit()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

On 03/12/2013 09:52 AM, Peter Lieven wrote:
> this patch adds the usage of buffer_find_nonzero_offset()
> to skip large areas of zeroes.
> 
> compared to loop unrolling this adds another 50% performance
> benefit for skipping large areas of zeroes.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>  util/bitops.c |   23 ++++++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)

> +        if (((uintptr_t) p) % sizeof(VECTYPE) == 0
> +              && size >= BITS_PER_BYTE*8*sizeof(VECTYPE)) {

Spaces around binary operators.  CHAR_BITS instead of magic 8.

> +          unsigned long tmp2 =
> +              buffer_find_nonzero_offset(p, ((size/BITS_PER_BYTE) &
> ~(8*sizeof(VECTYPE)-1)));

Spaces around binary operators.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]