From: Stephen Warren <swarren@wwwdotorg.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Chris Ball <cjb@laptop.org>,
Anton Vorontsov <avorontsov@ru.mvista.com>,
Viresh Kumar <viresh.linux@gmail.com>,
Mike Rapoport <mike@compulab.co.il>,
Shawn Guo <shawn.guo@linaro.org>,
Albert Herranz <albert_herranz@yahoo.es>,
Kevin Liu <kliu5@marvell.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: sdhci_pltfm: Constify sdhci_pltfm_data
Date: Tue, 12 Mar 2013 12:15:59 -0600 [thread overview]
Message-ID: <513F70DF.2000708@wwwdotorg.org> (raw)
In-Reply-To: <1363085580-3690-1-git-send-email-lars@metafoo.de>
On 03/12/2013 04:52 AM, Lars-Peter Clausen wrote:
> The sdhci_pltfm_data struct is never modified within the sdhci_pltfm module. So
> make the pdata parameter to sdhci_pltfm_init and sdhci_pltfm_register const.
> This allows drivers to declare their sdhci_pltfm_data struct as const.
>
> This patch also makes the sdhci_pltfm_data declarations const where possible.
> No changes since the last submission, just rebased onto of the latest mmc-next
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> -static struct sdhci_pltfm_data sdhci_tegra20_pdata = {
> +static const struct sdhci_pltfm_data sdhci_tegra20_pdata = {
> -static struct sdhci_pltfm_data sdhci_tegra30_pdata = {
> +static const struct sdhci_pltfm_data sdhci_tegra30_pdata = {
Commit 5ebf255 "mmc: sdhci-tegra: add basic support for Tegra114"
recently added sdhci_tegra114_pdata, which would need the same treatment.
next prev parent reply other threads:[~2013-03-12 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 10:52 [PATCH 1/3] mmc: sdhci_pltfm: Constify sdhci_pltfm_data Lars-Peter Clausen
2013-03-12 10:52 ` [PATCH 2/3] mmc: sdhci-pltfm: Constify the ops field of sdhci_pltfm_data struct Lars-Peter Clausen
2013-03-12 10:53 ` [PATCH 3/3] mmc: sdhci: Constify sdhci_ops structs where possible Lars-Peter Clausen
2013-03-12 18:15 ` Stephen Warren [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-14 18:06 [PATCH 1/3] mmc: sdhci_pltfm: Constify sdhci_pltfm_data Lars-Peter Clausen
2013-02-18 2:58 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F70DF.2000708@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=albert_herranz@yahoo.es \
--cc=avorontsov@ru.mvista.com \
--cc=cjb@laptop.org \
--cc=kliu5@marvell.com \
--cc=lars@metafoo.de \
--cc=linux-mmc@vger.kernel.org \
--cc=mike@compulab.co.il \
--cc=shawn.guo@linaro.org \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.