From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 1/2 v2] ASoC: add
	snd_soc_register_component()
Date: Tue, 12 Mar 2013 19:57:47 +0100
Message-ID: <513F7AAB.8040401@metafoo.de>
References: <87fw06ace9.wl%kuninori.morimoto.gx@renesas.com>
 <87k3pdtnlk.wl%kuninori.morimoto.gx@renesas.com>
 <87ip4xtnka.wl%kuninori.morimoto.gx@renesas.com>
 <513F71BF.3040608@wwwdotorg.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from smtp-out-039.synserver.de (smtp-out-044.synserver.de
 [212.40.185.44])
 by alsa0.perex.cz (Postfix) with ESMTP id 9585D265F1A
 for <alsa-devel@alsa-project.org>; Tue, 12 Mar 2013 19:56:17 +0100 (CET)
In-Reply-To: <513F71BF.3040608@wwwdotorg.org>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Mark Brown <broonie@opensource.wolfsonmicro.com>, Simon <horms@verge.net.au>, Liam Girdwood <liam.r.girdwood@intel.com>, Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
List-Id: alsa-devel@alsa-project.org

On 03/12/2013 07:19 PM, Stephen Warren wrote:
> On 03/11/2013 07:27 PM, Kuninori Morimoto wrote:
>> Current ASoC has register function for platform/codec/dai/card,
>> but doesn't have for cpu.
>> It often produces confusion and fault on ASoC.
>>
>> As result of ASoC community discussion,
>> we consider new struct snd_soc_component for CPU/CODEC,
>> and will switch over to use it.
>>
>> This patch adds very basic struct snd_soc_component,
>> and register function for it.
> 
> The series seems reasonable enough to me, as a basis for future work on
> the DT stuff, so,
> 
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
> 
> I wonder how much work it is to convert all users of
> snd_soc_register_dais() to this new API; is it worth doing so?

If we allow the component driver to be NULL it's pretty much straight
forward using coccinelle. Don't know if it is worth it to conver them all
right away.

@@
expression dev;
@@
-snd_soc_register_dais(
+snd_soc_register_component(
 dev,
+NULL,
 ...)

@@
expression dev;
expression num_dais;
@@
-snd_soc_unregister_dais(
+snd_soc_unregister_component(
 dev,
-num_dais
 )

- Lars