From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] change default location for local.mk to $(CONFIG_DIR)
Date: Tue, 12 Mar 2013 22:47:07 +0100 [thread overview]
Message-ID: <513FA25B.5030908@mind.be> (raw)
In-Reply-To: <1706669320.395518.1363075932486.JavaMail.root@openwide.fr>
On 03/12/13 09:12, Jeremy Rosen wrote:
>> Dear J?r?my Rosen,
>>
>> On Thu, 7 Mar 2013 11:49:23 +0100, J?r?my Rosen wrote:
>>> the previous default of $(TOPDIR) broke the philosophy of builds
>>> with O=
>>> which try to keep all configuration files within the $(CONFIG_DIR)
>>> subtree
>>
>> Hum, that's an interesting vision of things. I think I would tend to
>> agree with this idea.
>>
>> What do others think?
>>
>
> A bit of context :
>
> I am trying to keep my buildroot project in git, but I am trying to
> cleanly separate "changes made to git" and "changes due to my project.
>
> that basically means that all config file needs to be out of the
> buildroot/ subdirectory to be able to easily generate patches against
> mainline and still keep my changes in git. I do that using git-subtree
>
> I also change the location of the kernel config file for the same reason
> and would do that for ctng and busybox if I needed to change them from
> their default config
But $(CONFIG_DIR) is not a good location then... $(CONFIG_DIR) is
$(TOPDIR) if doing in-tree build, and $(O) if doing out-of-tree build.
When you delete your out-of-tree dir, local.mk will also be gone...
I also don't really like the idea that with a defconfig, the build
result will be different when you change the O= command line parameter.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-03-12 21:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 10:49 [Buildroot] [PATCH] change default location for local.mk to $(CONFIG_DIR) Jérémy Rosen
2013-03-11 21:26 ` Thomas Petazzoni
2013-03-12 8:12 ` Jeremy Rosen
2013-03-12 21:47 ` Arnout Vandecappelle [this message]
2013-03-14 8:37 ` Jeremy Rosen
2013-03-18 6:46 ` Arnout Vandecappelle
2013-03-18 8:10 ` Jeremy Rosen
2013-03-12 8:26 ` Thomas De Schampheleire
2013-03-15 11:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513FA25B.5030908@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.