All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
To: CAI Qian <caiqian@redhat.com>
Cc: kexec <kexec@lists.infradead.org>
Subject: Re: failed to compile kexec from git
Date: Wed, 13 Mar 2013 11:19:19 +0800	[thread overview]
Message-ID: <513FF037.80308@cn.fujitsu.com> (raw)
In-Reply-To: <526259845.192944.1363143172053.JavaMail.root@redhat.com>

于 2013年03月13日 10:52, CAI Qian 写道:
> Looks like this is broken recently. I cloned the tree
> at the top commit been,
> 
> e73d481c4add17ee953c80bb4be72372d90d93d3
> ppc/uImage: Add support for RAM Disks
> 
> Then, error out.
> 
> kexec/arch/i386/x86-linux-setup.c: In function ‘setup_linux_system_parameters’:
> kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’ undeclared (first use in this function)
> kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared identifier is reported only once for each function it appears in
> make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1
> 
> CAI Qian
> 

Hello CAI,

The below patch should fix the bug.

---
From 3511ddae28f50ec13f73c0d124c587ae5fe78048 Mon Sep 17 00:00:00 2001
From: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Date: Wed, 13 Mar 2013 11:10:36 +0800
Subject: [PATCH] kexec: i386: fix a bug due to parameter change

The kexec-tools fails to be compiled and here is the error message:

kexec/arch/i386/x86-linux-setup.c: In function ‘setup_linux_system_parameters’:
kexec/arch/i386/x86-linux-setup.c:511:9: error: ‘kexec_flags’ undeclared (first use in this function)
kexec/arch/i386/x86-linux-setup.c:511:9: note: each undeclared identifier is reported only once for each function it appears in
make: *** [kexec/arch/i386/x86-linux-setup.o] Error 1

This is due to the parameter change of function setup_linux_system_parameters,
and the bug was imported by commit 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36
    kexec x86: drop truncation warning for crash kernel

The patch fix the bug.

Reported-by: "CAI Qian" <caiqian@redhat.com>
Signed-off-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
---
 kexec/arch/i386/x86-linux-setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
index b903d43..454fad6 100644
--- a/kexec/arch/i386/x86-linux-setup.c
+++ b/kexec/arch/i386/x86-linux-setup.c
@@ -508,7 +508,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
 	range = info->memory_range;
 	ranges = info->memory_ranges;
 	if (ranges > E820MAX) {
-		if (!(kexec_flags & KEXEC_ON_CRASH))
+		if (!(info->kexec_flags & KEXEC_ON_CRASH))
 			/*
 			 * this e820 not used for capture kernel, see
 			 * do_bzImage_load()
-- 
1.7.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2013-03-13  3:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13  2:52 failed to compile kexec from git CAI Qian
2013-03-13  3:08 ` CAI Qian
2013-03-13  9:52   ` Simon Horman
2013-03-13  9:57     ` Zhang Yanfei
2013-03-13 15:16       ` Simon Horman
2013-03-13  3:19 ` Zhang Yanfei [this message]
2013-03-13  4:23   ` WANG Chao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=513FF037.80308@cn.fujitsu.com \
    --to=zhangyanfei@cn.fujitsu.com \
    --cc=caiqian@redhat.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.