Re: [PATCH] Mandatory install device check for PowerPC

[avnish <avnish@imap.linux.ibm.com>]

Hi Vladimir,
Thank you so much for your response!

I have fine tuned the patch as per the last discussion (sorry, I missed 
the v2 tag). This latest patch will add install device check only to 
PowerPC machines. PowerMacs aren't affected by this change. The check is 
added when platform is detected as 
"GRUB_INSTALL_PLATFORM_POWERPC_IEEE1275" along with machine detected as 
non PowerMac. As per my Power platform analysis, currently in 
"grub_install.c", it detects PowerMacs based on the file system detected 
(HFS or HFS+) and set the "is_prep" as 0 based on this finding. This new 
check will only be applicable to PowerPC. And in case of PowerMacs, it 
will allow grub_install even without mentioning the install device.
Thank you!


Regards,
Avnish Chouhan
> ------------------------------
> 
> Message: 5
> Date: Fri, 8 Nov 2024 15:07:29 +0300
> From: "Vladimir 'phcoder' Serbinenko" <phcoder@gmail.com>
> To: The development of GNU GRUB <grub-devel@gnu.org>
> Subject: Re: [PATCH] Mandatory install device check for PowerPC
> Message-ID:
> 	<CAEaD8JMqP4_uP5cZutSMGWvGMxbHAvNh10VCMO4ZcbqvLAQ9zw@mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
> 
> As discussed in another thread, this breaks installing from x86 onto
> removable disk for PPC Mac which is a supported workflow
> 
> Le ven. 8 nov. 2024, 14:13, Avnish Chouhan <avnish@linux.ibm.com> a 
> écrit :
> 
>> This patch adds a check on install_device while installing grub for
>> PowerPC.
>> If install_device is not mentioned in grub2-install and machine is 
>> detected
>> as PowerPC, the error will be thrown and it will terminates the
>> grub2-install
>> operation. Running grub2-install on PowerPC without the install_device 
>> may
>> result in bootlist corruption. When no install device is specified, it
>> attempts
>> to load images from the filesystem, which leads to nvram bootlist
>> corruption.
>> The idea is to fail the operation and avoid creating the invalid boot
>> entry.
>> 
>> Signed-off-by: Avnish Chouhan <avnish@linux.ibm.com>
>> ---
>>  grub-install.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>> 
>> diff --git a/util/grub-install.c b/util/grub-install.c
>> index 7dc5657..a049f53 100644
>> --- a/util/grub-install.c
>> +++ b/util/grub-install.c
>> @@ -1289,6 +1289,17 @@ main (int argc, char *argv[])
>>               is_prep = 0;
>>             }
>>         }
>> +      else
>> +        {
>> +         /*
>> +          * As the machine has been detected as PowerPC and not the
>> PowerMac. We need to check
>> +          * whether the install_device has been mentioned while
>> installing. If no device has been
>> +          * mentioned, we need to exit and mark it as an error as the
>> install_device is required for
>> +          * PowerPC installation. An installation with no device
>> mentioned may lead to corruptions.
>> +          */
>> +           if (!install_device)
>> +             grub_util_error ("%s", _("install device isn't specified
>> required for PowerPC"));
>> +        }
>>      }
>> 
>>    size_t ndev = 0;
>> --
>> 2.39.3
>> 
>> 
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>> 
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL:
> <https://lists.gnu.org/archive/html/grub-devel/attachments/20241108/22e8b62a/attachment.htm>
> 
> ------------------------------
> 
> Subject: Digest Footer
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 
> 
> ------------------------------
> 
> End of Grub-devel Digest, Vol 249, Issue 30
> *******************************************

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel