All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rymarkiewicz Waldemar <waldemar.rymarkiewicz@tieto.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [RFC] bloodpressure: Add Blood Pressure API
Date: Wed, 13 Mar 2013 07:51:33 +0100	[thread overview]
Message-ID: <514021F5.1040005@tieto.com> (raw)
In-Reply-To: <513703AA.2090206@tieto.com>

Hi,

>>> +Interface	org.bluez.BloodPressure1
>>> +Object path	[variable prefix]/{hci0,hci1,...}/dev_XX_XX_XX_XX_XX_XX
>>> +
>>> +Methods		RegisterWatcher(object watcher)
>>> +
>>> +			Registers a watcher to monitor blood pressure
>>> +			measurements. This watcher will be notified about
>>> +			final pressure measurements.
>>> +
>>> +			Possible Errors: org.bluez.Error.InvalidArguments
>>> +
>>> +		UnregisterWatcher(object watcher)
>>> +
>>> +			Unregisters a watcher.
>>> +
>>> +		EnableIntermediateMeasurement(object watcher)
>>> +
>>> +			Enables intermediate measurement notifications
>>> +			for this watcher. Intermediate measurements will
>>> +			be enabled only for devices which support it.
>>> +
>>> +			Possible Errors: org.bluez.Error.InvalidArguments
>>> +					org.bluez.Error.NotSupported
>>> +
>>> +		DisableIntermediateMeasurement(object watcher)
>>> +
>>> +			Disables intermediate measurement notifications
>>> +			for this watcher. It will disable notifications in
>>> +			devices when the last watcher is removed for
>>> +			intermediate measurements.
>>> +
>>> +			Possible Errors: org.bluez.Error.InvalidArguments
>>> +					org.bluez.Error.NotFound
>>
>> why don't we make these two methods parts of a dict for RegisterWatcher. Enabling them manually seems rather pointless.
>
> It's been done intentionally to be able to return "not supported" error
> when intermediate measurement is not available.
>
> Having RegisterWatcher(object watcher, boolean intermediate) and
> additionally Intermediate property [read only] is an another option.
>
> In this case app will check intermediate property and set intermediate
> param to RegisterWatcher appropriately.
>

Any comments on this.

/Waldek

  reply	other threads:[~2013-03-13  6:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-12 11:21 [RFC] bloodpressure: Add Blood Pressure API Waldemar Rymarkiewicz
2013-02-20  7:57 ` Johan Hedberg
2013-02-28 14:00   ` Rymarkiewicz Waldemar
2013-02-28 14:18     ` Johan Hedberg
2013-03-01  8:34       ` Rymarkiewicz Waldemar
2013-03-01  8:39         ` Johan Hedberg
2013-03-01 12:11       ` Rymarkiewicz Waldemar
2013-03-01 13:37         ` Johan Hedberg
2013-03-02  3:09 ` Marcel Holtmann
2013-03-05 11:39   ` Rymarkiewicz Waldemar
2013-03-05 16:15     ` Marcel Holtmann
2013-03-06  8:51       ` Rymarkiewicz Waldemar
2013-03-13  6:51         ` Rymarkiewicz Waldemar [this message]
2013-05-08  7:41           ` Johan Hedberg
2013-05-16 12:17             ` Waldemar Rymarkiewicz
2013-05-16 12:22               ` Waldemar Rymarkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514021F5.1040005@tieto.com \
    --to=waldemar.rymarkiewicz@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.