From: Patrice CHOTARD <patrice.chotard@st.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Axel Lin <axel.lin@ingics.com>, Lee Jones <lee.jones@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register
Date: Wed, 13 Mar 2013 15:33:29 +0100 [thread overview]
Message-ID: <51408E39.80406@st.com> (raw)
In-Reply-To: <CACRpkda-BvUQKPPC9rrQiG=p0OUtaqrtYp7uveBFopgqu_WdhQ@mail.gmail.com>
On 03/13/2013 02:59 PM, Linus Walleij wrote:
> On Tue, Mar 5, 2013 at 7:58 AM, Axel Lin <axel.lin@ingics.com> wrote:
>
>> It's pointless to check "af.alt_bit1 == UNUSED" twice.
>> This looks like a copy-paste bug, I think what we want is to check if *both*
>> af.alt_bit1 and af.alt_bit2 are UNUSED.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Tentatively applied to fixes, waiting for Patrice to confirm...
>
> Thanks!
> Linus Walleij
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Patrice
prev parent reply other threads:[~2013-03-13 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 6:58 [PATCH RFT] pinctrl: abx500: Fix checking if pin use AlternateFunction register Axel Lin
2013-03-13 13:59 ` Linus Walleij
2013-03-13 14:33 ` Patrice CHOTARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51408E39.80406@st.com \
--to=patrice.chotard@st.com \
--cc=axel.lin@ingics.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.