From: Jan Kiszka <jan.kiszka@siemens.com>
To: Xenomai <xenomai@xenomai.org>
Subject: [Xenomai] [PATCH] Do not overwrite pre-existing SIGDEBUG handler in xeno_skin_bind
Date: Wed, 13 Mar 2013 15:53:34 +0100 [thread overview]
Message-ID: <514092EE.5090406@siemens.com> (raw)
In case the application already set a SIGDEBUG handler, let that one
handle any potential SIGDEBUG_NOMLOCK events and keep our handler
(xeno_handle_mlock_alert) out of the loop. This helps in scenarios where
skin libraries are loaded belatedly via dlopen.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
Anything that speaks against this? We ran into that issue with a large
application, and that can be one way to solve but should even make
sense in general.
include/asm-generic/bits/bind.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/include/asm-generic/bits/bind.h b/include/asm-generic/bits/bind.h
index 269be95..f39c853 100644
--- a/include/asm-generic/bits/bind.h
+++ b/include/asm-generic/bits/bind.h
@@ -23,6 +23,11 @@ xeno_bind_skin(unsigned skin_magic, const char *skin, const char *module)
exit(EXIT_FAILURE);
}
+ /* do not overwrite an already installed SIGDEBUG handler */
+ sigaction(SIGXCPU, NULL, &sa);
+ if (sa.sa_handler != SIG_DFL)
+ return muxid;
+
sa.sa_sigaction = xeno_handle_mlock_alert;
sigemptyset(&sa.sa_mask);
sa.sa_flags = SA_SIGINFO;
--
1.7.3.4
next reply other threads:[~2013-03-13 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 14:53 Jan Kiszka [this message]
2013-03-13 20:53 ` [Xenomai] [PATCH] Do not overwrite pre-existing SIGDEBUG handler in xeno_skin_bind Gilles Chanteperdrix
2013-03-14 12:09 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514092EE.5090406@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.