All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabien Chouteau <chouteau@adacore.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts
Date: Thu, 14 Mar 2013 11:59:39 +0100	[thread overview]
Message-ID: <5141AD9B.3060702@adacore.com> (raw)
In-Reply-To: <87mwu6z7ze.fsf@blackfin.pond.sub.org>

On 03/14/2013 09:44 AM, Markus Armbruster wrote:
> Fabien Chouteau <chouteau@adacore.com> writes:
>
>> We introduce a new command line option. It's a generic option to
>> customize the gdb server:
>>
>> -gdb-opts [attached=on|off]
>>
>> The only parameter for now is "attached".
>>
>> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
>
> --gdb-opts complements existing --gdb.  You need to use both for full
> control.
>
> I figure you do this because you can't extend --gdb, as its argument is
> in legacy character device syntax, not QemuOpts.
>

That's right, maybe we can do some string manipulations to handle this case.

-gdb tcp::1234,attached=off

find ',attached={on|off}' and remove it from the string.

> We had similar cases before, and solved them differently: create a more
> general option, then make the old one sugar for the new one.
>
> For instance, --monitor and --qmp are sugar for --mon.  Desugaring code
> is in monitor_parse().
>

Something like:

-chardev socket,id=gdb1,host=localhost,port=1234,server,nowait,nodelay -gdb-remote chardev=gdb1,attached=off

You still need two options for full control.

Regards,

-- 
Fabien Chouteau

  reply	other threads:[~2013-03-14 10:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 17:31 [Qemu-devel] [PATCH V3 0/3] Add GDB qAttached support Fabien Chouteau
2013-03-12 17:31 ` [Qemu-devel] [PATCH V3 1/3] " Fabien Chouteau
2013-03-14 19:51   ` [Qemu-devel] [PATCH v4] " Jan Kiszka
2013-03-14 21:07     ` Jesse Larrew
2013-03-15 12:02       ` Fabien Chouteau
2013-03-19 10:37         ` Fabien Chouteau
2013-05-01 14:18     ` Jan Kiszka
2013-03-12 17:31 ` [Qemu-devel] [PATCH V3 2/3] Revert "gdbstub: Do not kill target in system emulation mode" Fabien Chouteau
2013-03-14 19:52   ` Jan Kiszka
2013-03-12 17:31 ` [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts Fabien Chouteau
2013-03-14  8:44   ` Markus Armbruster
2013-03-14 10:59     ` Fabien Chouteau [this message]
2013-03-14 12:34       ` Markus Armbruster
2013-03-14 16:33         ` Fabien Chouteau
2013-03-19 14:31           ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5141AD9B.3060702@adacore.com \
    --to=chouteau@adacore.com \
    --cc=armbru@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.