From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36341)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1UG5sx-0005tP-NI
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 06:59:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1UG5sr-0007yR-IX
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 06:59:47 -0400
Received: from mel.act-europe.fr ([194.98.77.210]:48255)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chouteau@adacore.com>) id 1UG5sr-0007w4-Ax
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 06:59:41 -0400
Message-ID: <5141AD9B.3060702@adacore.com>
Date: Thu, 14 Mar 2013 11:59:39 +0100
From: Fabien Chouteau <chouteau@adacore.com>
MIME-Version: 1.0
References: <1363109492-1901-1-git-send-email-chouteau@adacore.com>
	<1363109492-1901-4-git-send-email-chouteau@adacore.com>
	<87mwu6z7ze.fsf@blackfin.pond.sub.org>
In-Reply-To: <87mwu6z7ze.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org

On 03/14/2013 09:44 AM, Markus Armbruster wrote:
> Fabien Chouteau <chouteau@adacore.com> writes:
>
>> We introduce a new command line option. It's a generic option to
>> customize the gdb server:
>>
>> -gdb-opts [attached=on|off]
>>
>> The only parameter for now is "attached".
>>
>> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
>
> --gdb-opts complements existing --gdb.  You need to use both for full
> control.
>
> I figure you do this because you can't extend --gdb, as its argument is
> in legacy character device syntax, not QemuOpts.
>

That's right, maybe we can do some string manipulations to handle this case.

-gdb tcp::1234,attached=off

find ',attached={on|off}' and remove it from the string.

> We had similar cases before, and solved them differently: create a more
> general option, then make the old one sugar for the new one.
>
> For instance, --monitor and --qmp are sugar for --mon.  Desugaring code
> is in monitor_parse().
>

Something like:

-chardev socket,id=gdb1,host=localhost,port=1234,server,nowait,nodelay -gdb-remote chardev=gdb1,attached=off

You still need two options for full control.

Regards,

-- 
Fabien Chouteau