From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 4/5] lvm2app: Move core lv re-size code (v2)
Date: Thu, 14 Mar 2013 15:17:19 +0100 [thread overview]
Message-ID: <5141DBEF.8040309@redhat.com> (raw)
In-Reply-To: <1363212806-16025-4-git-send-email-tasleson@redhat.com>
Dne 13.3.2013 23:13, Tony Asleson napsal(a):
> Moved to allow use from command line and for library use.
>
> Signed-off-by: Tony Asleson <tasleson@redhat.com>
> ---
> lib/metadata/lv_manip.c | 734 +++++++++++++++++++++++++++++++++++++
> lib/metadata/metadata-exported.h | 46 +++
> tools/lvresize.c | 771 ---------------------------------------
> 3 files changed, 780 insertions(+), 771 deletions(-)
>
> diff --git a/lib/metadata/metadata-exported.h b/lib/metadata/metadata-exported.h
> index c2728d5..a792fd2 100644
> --- a/lib/metadata/metadata-exported.h
> +++ b/lib/metadata/metadata-exported.h
> @@ -419,6 +419,49 @@ struct pvcreate_params {
> struct pvcreate_restorable_params rp;
> };
>
> +struct lvresize_params {
> + const char *vg_name;
> + const char *lv_name;
> +
> + uint32_t stripes;
> + uint32_t stripe_size;
> + uint32_t mirrors;
> +
Here we should think about - whether there should be one
generic '_params' object with subsection (?unions?)
for various operations - since there is a lot of common
options between lvcreate/lvconvert/lvresize....
lvm2api then might create access(set/get) methods to prepare this object
and pass this handle into more generic function.
Zdenek
next prev parent reply other threads:[~2013-03-14 14:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:13 [PATCH 1/5] lvm2app: Implementation of pv resize (v6) Tony Asleson
2013-03-13 22:13 ` [PATCH 2/5] lvm2app: Move percent_of_extents to lvm-percent.[h|c] Tony Asleson
2013-03-13 22:13 ` [PATCH 3/5] lvm2app: Rework argument handling for lv resize Tony Asleson
2013-03-13 22:13 ` [PATCH 4/5] lvm2app: Move core lv re-size code (v2) Tony Asleson
2013-03-14 14:12 ` Zdenek Kabelac
2013-03-14 15:12 ` Tony Asleson
2013-03-14 15:14 ` Zdenek Kabelac
2013-03-14 15:29 ` Tony Asleson
2013-03-14 15:39 ` Zdenek Kabelac
2013-03-14 14:17 ` Zdenek Kabelac [this message]
2013-03-13 22:13 ` [PATCH 5/5] lvm2app: Implement lv resize Tony Asleson
-- strict thread matches above, loose matches on Subject: below --
2013-03-14 18:14 [PATCH 1/5] lvm2app: Implementation of pv resize (v6) Tony Asleson
2013-03-14 18:14 ` [PATCH 4/5] lvm2app: Move core lv re-size code (v2) Tony Asleson
2013-03-15 8:17 ` Zdenek Kabelac
2013-03-15 16:30 ` Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5141DBEF.8040309@redhat.com \
--to=zkabelac@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.