From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UGECp-00071D-07
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 15:52:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UGECn-0003wc-Pc
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 15:52:50 -0400
Received: from david.siemens.de ([192.35.17.14]:33875)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1UGECn-0003wX-Ek
	for qemu-devel@nongnu.org; Thu, 14 Mar 2013 15:52:49 -0400
Message-ID: <51422A8E.50802@siemens.com>
Date: Thu, 14 Mar 2013 20:52:46 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1363109492-1901-1-git-send-email-chouteau@adacore.com>
	<1363109492-1901-3-git-send-email-chouteau@adacore.com>
In-Reply-To: <1363109492-1901-3-git-send-email-chouteau@adacore.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V3 2/3] Revert "gdbstub: Do not kill target
 in system emulation mode"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Fabien Chouteau <chouteau@adacore.com>

On 2013-03-12 18:31, Fabien Chouteau wrote:
> The requirements described in this patch are implemented by "Add GDB
> qAttached support".
> 
> This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8.
> 
> Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
> ---
>  gdbstub.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 70d54ce..0e94311 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2185,11 +2185,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
>              goto unknown_command;
>          }
>      case 'k':
> -#ifdef CONFIG_USER_ONLY
>          /* Kill the target */
>          fprintf(stderr, "\nQEMU: Terminated via GDBstub\n");
>          exit(0);
> -#endif
>      case 'D':
>          /* Detach packet */
>          gdb_breakpoint_remove_all();
> 

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Provided that v4 of "Add GDB qAttached support" is applied prior to this.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux