From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGPhd-0004F8-DY for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:09:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGPhc-0003Y9-AR for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:09:25 -0400 Received: from mail-ve0-f174.google.com ([209.85.128.174]:54036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGPhc-0003Xp-6h for qemu-devel@nongnu.org; Fri, 15 Mar 2013 04:09:24 -0400 Received: by mail-ve0-f174.google.com with SMTP id pb11so2348102veb.19 for ; Fri, 15 Mar 2013 01:09:23 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5142D72F.9080508@redhat.com> Date: Fri, 15 Mar 2013 09:09:19 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1363283830-22717-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1363283830-22717-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] configure: fix coroutine backend selection logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org Il 14/03/2013 18:57, Peter Maydell ha scritto: > The main aim of this patchset is patch 2, which changes the coroutine > backend selection logic so that it goes 'ucontext -> sigaltstack' > rather than 'ucontext -> gthread', since the gthread backend is > broken. To do this properly on all platforms we have to refactor > the code a bit (which it needed anyway). > > The first patch here is a generic configure cleanup to how we print > error messages, which I wanted for the third patch because otherwise > the various error paths would have been rather verbose. > > Changes v1->v2: > * fix the tests makefile too > * CONFIG_COROUTINE_BACKEND=foo rather than CONFIG_FOO_COROUTINE=y; > this simplifies both the configure code and the makefiles > * dropped the 'move upper()' patch as no longer needed (in this > series, anyway) > > Peter Maydell (2): > configure: Provide and use convenience error reporting function > configure: Don't fall back to gthread coroutine backend > > Makefile.objs | 11 +-- > configure | 257 ++++++++++++++++++++++++++------------------------------ > tests/Makefile | 14 +-- > 3 files changed, 119 insertions(+), 163 deletions(-) > Reviewed-by: Paolo Bonzini