From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: Florian Fainelli Message-ID: <514300E0.2030108@openwrt.org> Date: Fri, 15 Mar 2013 12:07:12 +0100 From: Florian Fainelli MIME-Version: 1.0 To: Florian Fainelli Subject: Re: [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver References: <1359473048-26551-1-git-send-email-florian@openwrt.org> <1363284515-9865-1-git-send-email-florian@openwrt.org> <1363284515-9865-5-git-send-email-florian@openwrt.org> In-Reply-To: <1363284515-9865-5-git-send-email-florian@openwrt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: Thomas Petazzoni , Andrew Lunn , Russell King , Jason Cooper , linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , netdev@vger.kernel.org, Paul Mackerras , linux-arm-kernel@lists.infradead.org, Rob Landley , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, Lennert Buytenhek List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 03/14/13 19:08, Florian Fainelli a écrit : > This patch converts the Marvell MV643XX ethernet driver to use the > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms > registering the Marvell MV643XX ethernet driver are also updated to > register a Marvell Orion MDIO driver. This driver voluntarily overlaps > with the Marvell Ethernet shared registers because it will use a subset > of this shared register (shared_base + 0x4 - shared_base + 0x84). The > Ethernet driver is also updated to look up for a PHY device using the > Orion MDIO bus driver. Thanks to the help of Andrew Lunn, there is at least two known issues with this patch version: - we need to move up the mvmdio line in drivers/net/ethernet/marvell/Makefile to make sure that configs having both mvmdio and mv643xx_eth built-in get the probing order right - the bus name used by mv643xx_eth is not the right now (orion-mdio.0 vs expected orion-mdio) so the PHY device will not be found during phy_connect() I will fix these two issues in the next version of the patchset. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: florian@openwrt.org (Florian Fainelli) Date: Fri, 15 Mar 2013 12:07:12 +0100 Subject: [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver In-Reply-To: <1363284515-9865-5-git-send-email-florian@openwrt.org> References: <1359473048-26551-1-git-send-email-florian@openwrt.org> <1363284515-9865-1-git-send-email-florian@openwrt.org> <1363284515-9865-5-git-send-email-florian@openwrt.org> Message-ID: <514300E0.2030108@openwrt.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 03/14/13 19:08, Florian Fainelli a ?crit : > This patch converts the Marvell MV643XX ethernet driver to use the > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms > registering the Marvell MV643XX ethernet driver are also updated to > register a Marvell Orion MDIO driver. This driver voluntarily overlaps > with the Marvell Ethernet shared registers because it will use a subset > of this shared register (shared_base + 0x4 - shared_base + 0x84). The > Ethernet driver is also updated to look up for a PHY device using the > Orion MDIO bus driver. Thanks to the help of Andrew Lunn, there is at least two known issues with this patch version: - we need to move up the mvmdio line in drivers/net/ethernet/marvell/Makefile to make sure that configs having both mvmdio and mv643xx_eth built-in get the probing order right - the bus name used by mv643xx_eth is not the right now (orion-mdio.0 vs expected orion-mdio) so the PHY device will not be found during phy_connect() I will fix these two issues in the next version of the patchset. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 4/4 v2] mv643xx_eth: convert to use the Marvell Orion MDIO driver Date: Fri, 15 Mar 2013 12:07:12 +0100 Message-ID: <514300E0.2030108@openwrt.org> References: <1359473048-26551-1-git-send-email-florian@openwrt.org> <1363284515-9865-1-git-send-email-florian@openwrt.org> <1363284515-9865-5-git-send-email-florian@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1363284515-9865-5-git-send-email-florian@openwrt.org> Sender: linux-kernel-owner@vger.kernel.org To: Florian Fainelli Cc: davem@davemloft.net, Grant Likely , Rob Herring , Rob Landley , Jason Cooper , Andrew Lunn , Russell King , Benjamin Herrenschmidt , Paul Mackerras , Lennert Buytenhek , Thomas Petazzoni , Greg Kroah-Hartman , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org List-Id: devicetree@vger.kernel.org Le 03/14/13 19:08, Florian Fainelli a =C3=A9crit : > This patch converts the Marvell MV643XX ethernet driver to use the > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms > registering the Marvell MV643XX ethernet driver are also updated to > register a Marvell Orion MDIO driver. This driver voluntarily overlap= s > with the Marvell Ethernet shared registers because it will use a subs= et > of this shared register (shared_base + 0x4 - shared_base + 0x84). The > Ethernet driver is also updated to look up for a PHY device using the > Orion MDIO bus driver. Thanks to the help of Andrew Lunn, there is at least two known issues=20 with this patch version: - we need to move up the mvmdio line in=20 drivers/net/ethernet/marvell/Makefile to make sure that configs having=20 both mvmdio and mv643xx_eth built-in get the probing order right - the bus name used by mv643xx_eth is not the right now (orion-mdio.0 v= s=20 expected orion-mdio) so the PHY device will not be found during=20 phy_connect() I will fix these two issues in the next version of the patchset. -- =46lorian