From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v1 09/12] xl: add support for new hotplug
 interface to block-attach/detach
Date: Fri, 15 Mar 2013 12:54:48 +0100
Message-ID: <51430C08.3050703@citrix.com>
References: <1358963317-10221-1-git-send-email-roger.pau@citrix.com>
	<1358963317-10221-10-git-send-email-roger.pau@citrix.com>
	<20800.42974.49565.737910@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20800.42974.49565.737910@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13/03/13 17:22, Ian Jackson wrote:
> Roger Pau Monne writes ("[Xen-devel] [PATCH v1 09/12] xl: add support for new hotplug interface to block-attach/detach"):
>> Call prepare before attaching a block device.
> 
> Why is this helpful in xl ?

prepare function gets the hotplug version of the script and also
executes the prepare hotplug action if necessary. Failing to call
prepare would assume hotplug version is v1, so we won't be able to
block-attach devices using the v2 hotplug interface.