From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH v1 12/12] hotplug/Linux: add iscsi block
 hotplug script
Date: Fri, 15 Mar 2013 13:08:27 +0100
Message-ID: <51430F3B.8060300@citrix.com>
References: <1358963317-10221-1-git-send-email-roger.pau@citrix.com>
	<1358963317-10221-13-git-send-email-roger.pau@citrix.com>
	<20800.43492.41548.634968@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20800.43492.41548.634968@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 13/03/13 17:31, Ian Jackson wrote:
> Roger Pau Monne writes ("[Xen-devel] [PATCH v1 12/12] hotplug/Linux: add iscsi block hotplug script"):
>> This hotplug script has been tested with IET and NetBSD iSCSI targets,
>> without authentication.
>>
>> Authentication parameters, including the password are passed as
>> parameters to iscsiadm, which is not recommended because other users
>> of the system can see them. This parameters could also be set by
>> editing a corresponding file directly, but the location of this file
>> seems to be different depending on the distribution used.
> 
> Would it be possible for the user to specify the file that the
> password should be read from ?

AFAIK no, this is read from a system defined file, that can be different
depending on the distro used. Maybe be could expand this script latter
if needed, in order to be able to detect where this file resides and use
that instead of passing the user/password in the command line.

> 
> Did you write this script from scratch ?  (TBH I don't intend to
> review it in detail...)

I've found a previous version of iSCSI and Xen here:

http://backdrift.org/xen-block-iscsi-script-with-multipath-support

but I didn't use it, so yes.

> Why no set -e ?

Because some of the executed commands might fail, but that's expected
(and shouldn't abort the execution) and we manually check for the return
value of executed commands.

> Ian.
>