From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: Florian Fainelli Message-ID: <51431C0F.6080703@openwrt.org> Date: Fri, 15 Mar 2013 14:03:11 +0100 From: Florian Fainelli MIME-Version: 1.0 To: David Miller Subject: Re: [PATCH 0/4] mv643xx_eth: use mvmdio MDIO bus driver References: <20130315.085321.1047694772636447477.davem@davemloft.net> <20130315.085510.974056254781971889.davem@davemloft.net> <514319B6.7030307@openwrt.org> <20130315.090517.2027403317215151155.davem@davemloft.net> In-Reply-To: <20130315.090517.2027403317215151155.davem@davemloft.net> Content-Type: text/plain; charset=UTF-8; format=flowed Cc: thomas.petazzoni@free-electrons.com, andrew@lunn.ch, linux@arm.linux.org.uk, jason@lakedaemon.net, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, rob.herring@calxeda.com, netdev@vger.kernel.org, paulus@samba.org, linux-arm-kernel@lists.infradead.org, rob@landley.net, gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org, buytenh@wantstofly.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Le 03/15/13 14:05, David Miller a écrit : > From: Florian Fainelli > Date: Fri, 15 Mar 2013 13:53:10 +0100 > >> Le 03/15/13 13:55, David Miller a écrit : >>> From: David Miller >>> Date: Fri, 15 Mar 2013 08:53:21 -0400 (EDT) >>> >>>> From: Florian Fainelli >>>> Date: Thu, 14 Mar 2013 19:08:31 +0100 >>>> >>>>> This patch converts the mv643xx_eth driver to use the mvmdio MDIO bus >>>>> driver >>>>> instead of rolling its own implementation. As a result, all users of >>>>> this >>>>> mv643xx_eth driver are converted to register an "orion-mdio" >>>>> platform_device. >>>>> The mvmdio driver is also updated to support an interrupt line which >>>>> reports >>>>> SMI error/completion, and to allow traditionnal platform device >>>>> registration >>>>> instead of just device tree. >>>>> >>>>> David, I think it makes sense for you to merge all of this, since we >>>>> do >>>>> not want the architecture files to be desynchronized from the >>>>> mv643xx_eth to >>>>> avoid runtime breakage. The potential for merge conflicts should be >>>>> very small. >>>> >>>> All applied to net-next, thanks. >>> >>> Actually, reverted. Please send me code which actually compiles: >>> >>> drivers/net/ethernet/marvell/mvmdio.c: In function >>> ‘orion_mdio_wait_ready’: >>> drivers/net/ethernet/marvell/mvmdio.c:70:28: error: ‘NO_IRQ’ >>> undeclared (first use in this function) >>> drivers/net/ethernet/marvell/mvmdio.c:70:28: note: each undeclared >>> identifier is reported only once for each function it appears in >>> drivers/net/ethernet/marvell/mvmdio.c: In function ‘orion_mdio_probe’: >>> drivers/net/ethernet/marvell/mvmdio.c:242:24: error: ‘NO_IRQ’ >>> undeclared (first use in this function) >>> make[4]: *** [drivers/net/ethernet/marvell/mvmdio.o] Error 1 >>> >>> And don't use Kconfig dependencies to work around this, fix it >>> properly. >> >> Is there any platform out there for which we do not have a NO_IRQ >> definition by now? If so, what is it? > > Obviously if x86_64 doesn't even build your changes, that is one such > platform. Also, is grep not working on your computer? I built tested on PowerPC and ARM which are the platforms actually *using* these drivers and forgot that you build for x86_64. > > Platforms are absolutely no required to have this define, zero is the > only valid "no IRQ" which is portable in any way. > > This is an old and tired topic, portable code does not use NO_IRQ, and > that's simply the end of it. I changed not to rely on NO_IRQ anymore. Thanks! -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: florian@openwrt.org (Florian Fainelli) Date: Fri, 15 Mar 2013 14:03:11 +0100 Subject: [PATCH 0/4] mv643xx_eth: use mvmdio MDIO bus driver In-Reply-To: <20130315.090517.2027403317215151155.davem@davemloft.net> References: <20130315.085321.1047694772636447477.davem@davemloft.net> <20130315.085510.974056254781971889.davem@davemloft.net> <514319B6.7030307@openwrt.org> <20130315.090517.2027403317215151155.davem@davemloft.net> Message-ID: <51431C0F.6080703@openwrt.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 03/15/13 14:05, David Miller a ?crit : > From: Florian Fainelli > Date: Fri, 15 Mar 2013 13:53:10 +0100 > >> Le 03/15/13 13:55, David Miller a ?crit : >>> From: David Miller >>> Date: Fri, 15 Mar 2013 08:53:21 -0400 (EDT) >>> >>>> From: Florian Fainelli >>>> Date: Thu, 14 Mar 2013 19:08:31 +0100 >>>> >>>>> This patch converts the mv643xx_eth driver to use the mvmdio MDIO bus >>>>> driver >>>>> instead of rolling its own implementation. As a result, all users of >>>>> this >>>>> mv643xx_eth driver are converted to register an "orion-mdio" >>>>> platform_device. >>>>> The mvmdio driver is also updated to support an interrupt line which >>>>> reports >>>>> SMI error/completion, and to allow traditionnal platform device >>>>> registration >>>>> instead of just device tree. >>>>> >>>>> David, I think it makes sense for you to merge all of this, since we >>>>> do >>>>> not want the architecture files to be desynchronized from the >>>>> mv643xx_eth to >>>>> avoid runtime breakage. The potential for merge conflicts should be >>>>> very small. >>>> >>>> All applied to net-next, thanks. >>> >>> Actually, reverted. Please send me code which actually compiles: >>> >>> drivers/net/ethernet/marvell/mvmdio.c: In function >>> ?orion_mdio_wait_ready?: >>> drivers/net/ethernet/marvell/mvmdio.c:70:28: error: ?NO_IRQ? >>> undeclared (first use in this function) >>> drivers/net/ethernet/marvell/mvmdio.c:70:28: note: each undeclared >>> identifier is reported only once for each function it appears in >>> drivers/net/ethernet/marvell/mvmdio.c: In function ?orion_mdio_probe?: >>> drivers/net/ethernet/marvell/mvmdio.c:242:24: error: ?NO_IRQ? >>> undeclared (first use in this function) >>> make[4]: *** [drivers/net/ethernet/marvell/mvmdio.o] Error 1 >>> >>> And don't use Kconfig dependencies to work around this, fix it >>> properly. >> >> Is there any platform out there for which we do not have a NO_IRQ >> definition by now? If so, what is it? > > Obviously if x86_64 doesn't even build your changes, that is one such > platform. Also, is grep not working on your computer? I built tested on PowerPC and ARM which are the platforms actually *using* these drivers and forgot that you build for x86_64. > > Platforms are absolutely no required to have this define, zero is the > only valid "no IRQ" which is portable in any way. > > This is an old and tired topic, portable code does not use NO_IRQ, and > that's simply the end of it. I changed not to rely on NO_IRQ anymore. Thanks! -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 0/4] mv643xx_eth: use mvmdio MDIO bus driver Date: Fri, 15 Mar 2013 14:03:11 +0100 Message-ID: <51431C0F.6080703@openwrt.org> References: <20130315.085321.1047694772636447477.davem@davemloft.net> <20130315.085510.974056254781971889.davem@davemloft.net> <514319B6.7030307@openwrt.org> <20130315.090517.2027403317215151155.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20130315.090517.2027403317215151155.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: David Miller Cc: andrew-g2DYL2Zd6BY@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, buytenh-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org List-Id: devicetree@vger.kernel.org TGUgMDMvMTUvMTMgMTQ6MDUsIERhdmlkIE1pbGxlciBhIMOpY3JpdCA6Cj4gRnJvbTogRmxvcmlh biBGYWluZWxsaSA8ZmxvcmlhbkBvcGVud3J0Lm9yZz4KPiBEYXRlOiBGcmksIDE1IE1hciAyMDEz IDEzOjUzOjEwICswMTAwCj4KPj4gTGUgMDMvMTUvMTMgMTM6NTUsIERhdmlkIE1pbGxlciBhIMOp Y3JpdCA6Cj4+PiBGcm9tOiBEYXZpZCBNaWxsZXIgPGRhdmVtQGRhdmVtbG9mdC5uZXQ+Cj4+PiBE YXRlOiBGcmksIDE1IE1hciAyMDEzIDA4OjUzOjIxIC0wNDAwIChFRFQpCj4+Pgo+Pj4+IEZyb206 IEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW5Ab3BlbndydC5vcmc+Cj4+Pj4gRGF0ZTogVGh1LCAx NCBNYXIgMjAxMyAxOTowODozMSArMDEwMAo+Pj4+Cj4+Pj4+IFRoaXMgcGF0Y2ggY29udmVydHMg dGhlIG12NjQzeHhfZXRoIGRyaXZlciB0byB1c2UgdGhlIG12bWRpbyBNRElPIGJ1cwo+Pj4+PiBk cml2ZXIKPj4+Pj4gaW5zdGVhZCBvZiByb2xsaW5nIGl0cyBvd24gaW1wbGVtZW50YXRpb24uIEFz IGEgcmVzdWx0LCBhbGwgdXNlcnMgb2YKPj4+Pj4gdGhpcwo+Pj4+PiBtdjY0M3h4X2V0aCBkcml2 ZXIgYXJlIGNvbnZlcnRlZCB0byByZWdpc3RlciBhbiAib3Jpb24tbWRpbyIKPj4+Pj4gcGxhdGZv cm1fZGV2aWNlLgo+Pj4+PiBUaGUgbXZtZGlvIGRyaXZlciBpcyBhbHNvIHVwZGF0ZWQgdG8gc3Vw cG9ydCBhbiBpbnRlcnJ1cHQgbGluZSB3aGljaAo+Pj4+PiByZXBvcnRzCj4+Pj4+IFNNSSBlcnJv ci9jb21wbGV0aW9uLCBhbmQgdG8gYWxsb3cgdHJhZGl0aW9ubmFsIHBsYXRmb3JtIGRldmljZQo+ Pj4+PiByZWdpc3RyYXRpb24KPj4+Pj4gaW5zdGVhZCBvZiBqdXN0IGRldmljZSB0cmVlLgo+Pj4+ Pgo+Pj4+PiBEYXZpZCwgSSB0aGluayBpdCBtYWtlcyBzZW5zZSBmb3IgeW91IHRvIG1lcmdlIGFs bCBvZiB0aGlzLCBzaW5jZSB3ZQo+Pj4+PiBkbwo+Pj4+PiBub3Qgd2FudCB0aGUgYXJjaGl0ZWN0 dXJlIGZpbGVzIHRvIGJlIGRlc3luY2hyb25pemVkIGZyb20gdGhlCj4+Pj4+IG12NjQzeHhfZXRo IHRvCj4+Pj4+IGF2b2lkIHJ1bnRpbWUgYnJlYWthZ2UuIFRoZSBwb3RlbnRpYWwgZm9yIG1lcmdl IGNvbmZsaWN0cyBzaG91bGQgYmUKPj4+Pj4gdmVyeSBzbWFsbC4KPj4+Pgo+Pj4+IEFsbCBhcHBs aWVkIHRvIG5ldC1uZXh0LCB0aGFua3MuCj4+Pgo+Pj4gQWN0dWFsbHksIHJldmVydGVkLiAgUGxl YXNlIHNlbmQgbWUgY29kZSB3aGljaCBhY3R1YWxseSBjb21waWxlczoKPj4+Cj4+PiBkcml2ZXJz L25ldC9ldGhlcm5ldC9tYXJ2ZWxsL212bWRpby5jOiBJbiBmdW5jdGlvbgo+Pj4g4oCYb3Jpb25f bWRpb193YWl0X3JlYWR54oCZOgo+Pj4gZHJpdmVycy9uZXQvZXRoZXJuZXQvbWFydmVsbC9tdm1k aW8uYzo3MDoyODogZXJyb3I6IOKAmE5PX0lSUeKAmQo+Pj4gdW5kZWNsYXJlZCAoZmlyc3QgdXNl IGluIHRoaXMgZnVuY3Rpb24pCj4+PiBkcml2ZXJzL25ldC9ldGhlcm5ldC9tYXJ2ZWxsL212bWRp by5jOjcwOjI4OiBub3RlOiBlYWNoIHVuZGVjbGFyZWQKPj4+IGlkZW50aWZpZXIgaXMgcmVwb3J0 ZWQgb25seSBvbmNlIGZvciBlYWNoIGZ1bmN0aW9uIGl0IGFwcGVhcnMgaW4KPj4+IGRyaXZlcnMv bmV0L2V0aGVybmV0L21hcnZlbGwvbXZtZGlvLmM6IEluIGZ1bmN0aW9uIOKAmG9yaW9uX21kaW9f cHJvYmXigJk6Cj4+PiBkcml2ZXJzL25ldC9ldGhlcm5ldC9tYXJ2ZWxsL212bWRpby5jOjI0Mjoy NDogZXJyb3I6IOKAmE5PX0lSUeKAmQo+Pj4gdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMg ZnVuY3Rpb24pCj4+PiBtYWtlWzRdOiAqKiogW2RyaXZlcnMvbmV0L2V0aGVybmV0L21hcnZlbGwv bXZtZGlvLm9dIEVycm9yIDEKPj4+Cj4+PiBBbmQgZG9uJ3QgdXNlIEtjb25maWcgZGVwZW5kZW5j aWVzIHRvIHdvcmsgYXJvdW5kIHRoaXMsIGZpeCBpdAo+Pj4gcHJvcGVybHkuCj4+Cj4+IElzIHRo ZXJlIGFueSBwbGF0Zm9ybSBvdXQgdGhlcmUgZm9yIHdoaWNoIHdlIGRvIG5vdCBoYXZlIGEgTk9f SVJRCj4+IGRlZmluaXRpb24gYnkgbm93PyBJZiBzbywgd2hhdCBpcyBpdD8KPgo+IE9idmlvdXNs eSBpZiB4ODZfNjQgZG9lc24ndCBldmVuIGJ1aWxkIHlvdXIgY2hhbmdlcywgdGhhdCBpcyBvbmUg c3VjaAo+IHBsYXRmb3JtLiAgQWxzbywgaXMgZ3JlcCBub3Qgd29ya2luZyBvbiB5b3VyIGNvbXB1 dGVyPwoKSSBidWlsdCB0ZXN0ZWQgb24gUG93ZXJQQyBhbmQgQVJNIHdoaWNoIGFyZSB0aGUgcGxh dGZvcm1zIGFjdHVhbGx5IAoqdXNpbmcqIHRoZXNlIGRyaXZlcnMgYW5kIGZvcmdvdCB0aGF0IHlv dSBidWlsZCBmb3IgeDg2XzY0LgoKPgo+IFBsYXRmb3JtcyBhcmUgYWJzb2x1dGVseSBubyByZXF1 aXJlZCB0byBoYXZlIHRoaXMgZGVmaW5lLCB6ZXJvIGlzIHRoZQo+IG9ubHkgdmFsaWQgIm5vIElS USIgd2hpY2ggaXMgcG9ydGFibGUgaW4gYW55IHdheS4KPgo+IFRoaXMgaXMgYW4gb2xkIGFuZCB0 aXJlZCB0b3BpYywgcG9ydGFibGUgY29kZSBkb2VzIG5vdCB1c2UgTk9fSVJRLCBhbmQKPiB0aGF0 J3Mgc2ltcGx5IHRoZSBlbmQgb2YgaXQuCgpJIGNoYW5nZWQgbm90IHRvIHJlbHkgb24gTk9fSVJR IGFueW1vcmUuIFRoYW5rcyEKLS0KRmxvcmlhbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkZXZpY2V0cmVlLWRpc2N1c3MgbWFpbGluZyBsaXN0CmRldmlj ZXRyZWUtZGlzY3Vzc0BsaXN0cy5vemxhYnMub3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9s aXN0aW5mby9kZXZpY2V0cmVlLWRpc2N1c3MK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754783Ab3CONGs (ORCPT ); Fri, 15 Mar 2013 09:06:48 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:46750 "EHLO mail-ee0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754682Ab3CONGp (ORCPT ); Fri, 15 Mar 2013 09:06:45 -0400 Message-ID: <51431C0F.6080703@openwrt.org> Date: Fri, 15 Mar 2013 14:03:11 +0100 From: Florian Fainelli Organization: OpenWrt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: David Miller CC: grant.likely@secretlab.ca, rob.herring@calxeda.com, rob@landley.net, jason@lakedaemon.net, andrew@lunn.ch, linux@arm.linux.org.uk, benh@kernel.crashing.org, paulus@samba.org, buytenh@wantstofly.org, thomas.petazzoni@free-electrons.com, gregkh@linuxfoundation.org, devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: Re: [PATCH 0/4] mv643xx_eth: use mvmdio MDIO bus driver References: <20130315.085321.1047694772636447477.davem@davemloft.net> <20130315.085510.974056254781971889.davem@davemloft.net> <514319B6.7030307@openwrt.org> <20130315.090517.2027403317215151155.davem@davemloft.net> In-Reply-To: <20130315.090517.2027403317215151155.davem@davemloft.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 03/15/13 14:05, David Miller a écrit : > From: Florian Fainelli > Date: Fri, 15 Mar 2013 13:53:10 +0100 > >> Le 03/15/13 13:55, David Miller a écrit : >>> From: David Miller >>> Date: Fri, 15 Mar 2013 08:53:21 -0400 (EDT) >>> >>>> From: Florian Fainelli >>>> Date: Thu, 14 Mar 2013 19:08:31 +0100 >>>> >>>>> This patch converts the mv643xx_eth driver to use the mvmdio MDIO bus >>>>> driver >>>>> instead of rolling its own implementation. As a result, all users of >>>>> this >>>>> mv643xx_eth driver are converted to register an "orion-mdio" >>>>> platform_device. >>>>> The mvmdio driver is also updated to support an interrupt line which >>>>> reports >>>>> SMI error/completion, and to allow traditionnal platform device >>>>> registration >>>>> instead of just device tree. >>>>> >>>>> David, I think it makes sense for you to merge all of this, since we >>>>> do >>>>> not want the architecture files to be desynchronized from the >>>>> mv643xx_eth to >>>>> avoid runtime breakage. The potential for merge conflicts should be >>>>> very small. >>>> >>>> All applied to net-next, thanks. >>> >>> Actually, reverted. Please send me code which actually compiles: >>> >>> drivers/net/ethernet/marvell/mvmdio.c: In function >>> ‘orion_mdio_wait_ready’: >>> drivers/net/ethernet/marvell/mvmdio.c:70:28: error: ‘NO_IRQ’ >>> undeclared (first use in this function) >>> drivers/net/ethernet/marvell/mvmdio.c:70:28: note: each undeclared >>> identifier is reported only once for each function it appears in >>> drivers/net/ethernet/marvell/mvmdio.c: In function ‘orion_mdio_probe’: >>> drivers/net/ethernet/marvell/mvmdio.c:242:24: error: ‘NO_IRQ’ >>> undeclared (first use in this function) >>> make[4]: *** [drivers/net/ethernet/marvell/mvmdio.o] Error 1 >>> >>> And don't use Kconfig dependencies to work around this, fix it >>> properly. >> >> Is there any platform out there for which we do not have a NO_IRQ >> definition by now? If so, what is it? > > Obviously if x86_64 doesn't even build your changes, that is one such > platform. Also, is grep not working on your computer? I built tested on PowerPC and ARM which are the platforms actually *using* these drivers and forgot that you build for x86_64. > > Platforms are absolutely no required to have this define, zero is the > only valid "no IRQ" which is portable in any way. > > This is an old and tired topic, portable code does not use NO_IRQ, and > that's simply the end of it. I changed not to rely on NO_IRQ anymore. Thanks! -- Florian