All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests: test writing to device node on an RO filesystem
Date: Fri, 15 Mar 2013 11:11:12 -0500	[thread overview]
Message-ID: <51434820.6010100@sgi.com> (raw)
In-Reply-To: <514345D5.8090005@sandeen.net>

On 03/15/2013 11:01 AM, Eric Sandeen wrote:
> On 3/15/13 10:59 AM, Rich Johnston wrote:
>> Eric,
>>
>> Thanks again for the new test. A few minor issues that can be corrected at commit time.
>>
>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>
>> I can correct this a commit time.
>>
>> quilt refresh
>> Warning: trailing whitespace in line 24 of 306
>> Refreshed patch patches/V2-xfstests-test-writing-to-device-node-on-an-RO-filesystem.patch
>>
>> Do you also want me to add this top the quick group as Dave suggested when I commit this?
>
> Sure, thanks for that, and sorry my patches always seem so sloppy.  I mean well, and I try.  I'll try harder. ;)

Hehe no worries.

>
> -Eric
>
>> Thanks
>> --Rich
>>
>>
>>
>

This has been commited (with the correct test number this time ;) )

Thanks
--Rich

commit f835afd3f0f2bab78b5b303744bb9ad441276c02
Author: Eric Sandeen <sandeen@sandeen.net>
Date:   Fri Mar 15 02:37:34 2013 +0000

     xfstests: test writing to device node on an RO filesystem

     We should be able to open device nodes for writing even
     if they live on a readonly filesytem.

     Signed-off-by: Eric Sandeen <sandeen@redhat.com>
     Reviewed-by: Dave Chinner <dchinner@redhat.com>
     Reviewed-by: Rich Johnston <rjohnston@sgi.com>
     Signed-off-by: Rich Johnston <rjohnston@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-03-15 16:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-14 21:40 [PATCH] xfstests: test writing to device node on an RO filesystem Eric Sandeen
2013-03-14 23:20 ` Martin Steigerwald
2013-03-14 23:26   ` Eric Sandeen
2013-03-15  2:19 ` Dave Chinner
2013-03-15  2:37 ` [PATCH V2] " Eric Sandeen
2013-03-15  4:13   ` Dave Chinner
2013-03-15 15:59   ` Rich Johnston
2013-03-15 16:01     ` Eric Sandeen
2013-03-15 16:11       ` Rich Johnston [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51434820.6010100@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.