All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: "Keir (Xen.org)" <keir@xen.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [RFC PATCH V4 11/18] Bump EVTCHNS_PER_BUCKET to 512
Date: Fri, 15 Mar 2013 18:15:22 +0000	[thread overview]
Message-ID: <5143653A.7080406@citrix.com> (raw)
In-Reply-To: <1362486640-14707-12-git-send-email-wei.liu2@citrix.com>

On 05/03/13 12:30, Wei Liu wrote:
> For 64 bit build and 3-level event channel and the original value of
> EVTCHNS_PER_BUCKET (128), the space needed to accommodate d->evtchn would be 4
> pages (PAGE_SIZE = 4096). Given that not every domain needs 3-level event
> channel, this leads to waste of memory. Having EVTCHN_PER_BUCKETS to be 512
> can occupy exact one page.

This makes the list of buckets a page in size but each bucket is now 4
pages.

I think another layer of indirection is required to keep all the
allocations <= PAGE_SIZE.

David

> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
>  xen/include/xen/event.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/event.h b/xen/include/xen/event.h
> index 919f0e2..e2c3736 100644
> --- a/xen/include/xen/event.h
> +++ b/xen/include/xen/event.h
> @@ -39,7 +39,7 @@ static inline unsigned int max_evtchns(struct domain *d)
>      return ret;
>  }
>  
> -#define EVTCHNS_PER_BUCKET 128
> +#define EVTCHNS_PER_BUCKET 512
>  #define NR_EVTCHN_BUCKETS  (NR_EVENT_CHANNELS / EVTCHNS_PER_BUCKET)
>  
>  struct evtchn

  reply	other threads:[~2013-03-15 18:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05 12:30 [RFC PATCH V4] Implement 3-level event channel ABI in Xen Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 01/18] xen: correct BITS_PER_EVTCHN_WORD on arm Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 02/18] Clean up trailing whitespaces Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 03/18] Dynamically allocate d->evtchn Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 04/18] Move event channel macros / struct definition to proper place Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 05/18] Add d->max_evtchns Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 06/18] Add evtchn_is_{pending, masked} and evtchn_clear_pending Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 07/18] Implement extended event channel ABIs query Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 08/18] Define 3-level event channel registration interface Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 09/18] Add evtchn_extended in struct domain Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 10/18] Calculate max event channels for EVTCHN_EXTENDED_L3 Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 11/18] Bump EVTCHNS_PER_BUCKET to 512 Wei Liu
2013-03-15 18:15   ` David Vrabel [this message]
2013-03-15 18:37     ` Wei Liu
2013-03-15 18:43       ` David Vrabel
2013-03-05 12:30 ` [RFC PATCH V4 12/18] Update Xen public header xen.h Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 13/18] Genneralized event channel operations Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 14/18] Introduce EVTCHN_WORD_BITORDER macro Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 15/18] Infrastructure to manipulate 3-level event channel pages Wei Liu
2013-03-05 14:22   ` Jan Beulich
2013-03-05 12:30 ` [RFC PATCH V4 16/18] Implement 3-level event channel routines Wei Liu
2013-03-05 14:28   ` Jan Beulich
2013-03-05 16:07     ` Wei Liu
2013-03-05 16:13       ` Jan Beulich
2013-03-05 12:30 ` [RFC PATCH V4 17/18] Only allow extended event channel on Dom0 and driver domains Wei Liu
2013-03-05 12:30 ` [RFC PATCH V4 18/18] libxl: add evtchn_extended_allowed flag Wei Liu
2013-03-05 13:48   ` Ian Jackson
2013-03-05 17:11     ` Wei Liu
2013-03-05 17:38       ` Ian Jackson
2013-03-05 17:51         ` Wei Liu
2013-03-05 17:56           ` David Vrabel
2013-03-05 18:08             ` Wei Liu
2013-03-06 17:16               ` Wei Liu
2013-03-07 11:23                 ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5143653A.7080406@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.