All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mx6qsabrelite: Do not hardcode the CPU revision
Date: Sat, 16 Mar 2013 06:59:41 +0100	[thread overview]
Message-ID: <51440A4D.5060005@gmail.com> (raw)
In-Reply-To: <1363381594-17077-2-git-send-email-festevam@gmail.com>

Am 15.03.2013 22:06, schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Instead of hardcoding the CPU revision, it is better to use get_cpu_rev().

I think to remember that there is a reason why it is hard coded this 
way. Have you tested this with the Vivante GPU driver? If I remember 
correctly they check for exactly the 0x63000 and if it's not there, it 
won't work (?).

Best regards

Dirk

> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>   board/freescale/mx6qsabrelite/mx6qsabrelite.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 5b69a6d..9bd444e 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -26,6 +26,7 @@
>   #include <asm/arch/imx-regs.h>
>   #include <asm/arch/iomux.h>
>   #include <asm/arch/mx6q_pins.h>
> +#include <asm/arch/sys_proto.h>
>   #include <asm/errno.h>
>   #include <asm/gpio.h>
>   #include <asm/imx-common/iomux-v3.h>
> @@ -300,7 +301,7 @@ int board_mmc_init(bd_t *bis)
>
>   u32 get_board_rev(void)
>   {
> -	return 0x63000 ;
> +	return get_cpu_rev();
>   }
>
>   #ifdef CONFIG_MXC_SPI
>

  reply	other threads:[~2013-03-16  5:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-15 21:06 [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel Fabio Estevam
2013-03-15 21:06 ` [U-Boot] [PATCH 2/2] mx6qsabrelite: Do not hardcode the CPU revision Fabio Estevam
2013-03-16  5:59   ` Dirk Behme [this message]
2013-03-16  8:19     ` Wolfgang Denk
2013-03-16 14:50     ` Fabio Estevam
2013-03-16 14:52       ` Otavio Salvador
2013-03-16 15:01         ` Fabio Estevam
2013-03-16 16:32           ` Otavio Salvador
2013-03-16 19:41     ` Fabio Estevam
2013-03-16  0:20 ` [U-Boot] [PATCH 1/2] nitrogen6x: Pass the correct CPU revision to the kernel Eric Nelson
2013-03-16 14:58   ` Fabio Estevam
2013-03-16 16:13     ` Eric Nelson
2013-03-16 16:55       ` Dirk Behme
2013-03-16 20:17         ` Wolfgang Denk
2013-03-16 19:48       ` Fabio Estevam
2013-03-16 20:27         ` Eric Nelson
2013-03-25 19:14           ` Eric Nelson
2013-03-26  2:25             ` Fabio Estevam
2013-03-26  3:27               ` Fabio Estevam
2013-03-16 20:29         ` Wolfgang Denk
2013-03-16 20:14       ` Wolfgang Denk
2013-03-26 15:24 ` Eric Nelson
2013-03-26 15:26   ` Eric Nelson
2013-03-26 18:06   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51440A4D.5060005@gmail.com \
    --to=dirk.behme@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.