From: David Howells <dhowells@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, trond.myklebust@fys.uio.no,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3]
Date: Thu, 10 Mar 2005 12:57:48 +0000 [thread overview]
Message-ID: <5145.1110459468@redhat.com> (raw)
In-Reply-To: <5005.1110459008@redhat.com>
David Howells <dhowells@redhat.com> wrote:
> > What's with the preempt_enable()/disable() added to __key_link()? It's not
> > obvious what is being protected from what, and why.
>
> Ummm... Yes... They're probably not necessary. A wmb() may be required after
> the klist->nkeys++ to commit to memory the fact there's now an extra key link
> available, but I'm not sure that it's necessary.
I should perhaps be using smp_wmb() not wmb().
David
next prev parent reply other threads:[~2005-03-10 13:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 12:01 [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3] David Howells
2005-03-10 12:22 ` Andrew Morton
2005-03-10 12:50 ` David Howells
2005-03-10 12:57 ` David Howells [this message]
2005-03-10 13:02 ` Andrew Morton
2005-03-10 13:14 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5145.1110459468@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.