From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com [209.85.220.181]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 149DEE0147E for ; Sat, 16 Mar 2013 17:40:15 -0700 (PDT) Received: by mail-vc0-f181.google.com with SMTP id hv10so2134118vcb.40 for ; Sat, 16 Mar 2013 17:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=nHkkEYsVExxUOCR9WYqG0k/sWsiHoho6zYUrhS9ecFo=; b=HFd8T4SuilvTjA95M4kQ9qNJwMuZ9uiga2tbRm/5xDxA+23QZnIxdxfav+6gmeUJYI nHa/oXRoxEw6VggjqxVxuXSJfq9tuk0nk4JKPHy7O1mDGO9sF7fGGI/6fnluyyvFRdTb nyunL72QpbVxAPEnHKwfr4Xl7I28ahvA0xRjclE7xgmjTAcr21n20H3zzBWuD/rub6Iu 4zWD74kIPMIB+T0yWkUFEAuhiDAk/QW9PQriUrM3btaE5xN33QrbN7A6cS5jzkwCWHuf EEs1a1YyFY4Y6A3yNzsf630eSmDhKHs+fnGvDgBp097vzupuScSm+e8mqbAtexRYTR6q YSLQ== X-Received: by 10.52.29.209 with SMTP id m17mr11716070vdh.111.1363480815548; Sat, 16 Mar 2013 17:40:15 -0700 (PDT) Received: from goober.local ([75.76.228.60]) by mx.google.com with ESMTPS id j5sm13733682vdv.13.2013.03.16.17.40.14 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 16 Mar 2013 17:40:14 -0700 (PDT) Message-ID: <514510ED.2040603@gmail.com> Date: Sat, 16 Mar 2013 19:40:13 -0500 From: John Weber User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Otavio Salvador References: <1363441542-5300-1-git-send-email-rjohnweber@gmail.com> <1363441542-5300-6-git-send-email-rjohnweber@gmail.com> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: [meta-fsl-arm-extra][PATCH] linux-firmware: add support for bcm4329 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Mar 2013 00:40:16 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Otavio - I assume you mean this rename? +do_install_append() { + # Broadcom BCM4329 SDIO + cp -r ${D}/lib/firmware/brcm/brcmfmac4329.bin \ + ${D}/lib/firmware/brcm/brcmfmac-sdio.bin + cp -r ${WORKDIR}/brcmfmac-sdio.txt \ + ${D}/lib/firmware/brcm + cp -r ${D}/lib/firmware/LICENCE.broadcom_bcm43xx \ + ${D}/lib/firmware/brcm +} If I do not rename them, then the default kernel module for brcmfmac will not find the firmware files because it expects them to be named as above. From the driver in the mainline kernel (and also the backported driver, so it hasn't changed): drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c, line 317-320 #define BRCMF_SDIO_FW_NAME "brcm/brcmfmac-sdio.bin" #define BRCMF_SDIO_NV_NAME "brcm/brcmfmac-sdio.txt" MODULE_FIRMWARE(BRCMF_SDIO_FW_NAME); MODULE_FIRMWARE(BRCMF_SDIO_NV_NAME); I'll create a recipe to populate the nvram file separately from the kernel firmware. I can also do the rename there - is that what you are suggesting? If that is the case, then everyone that wants to use the brcmfmac driver will need to create their own recipe to do the copy (or a patch to the kernel to rename the files that the driver expects). In the end, I'll submit 2 patches instead of this 1 patch: - linux-firmware_git.bbappend - which will split the binaries only. - wandboard-wifi-support.bb - which will add the nvram file (.txt) and rename the binaries as the driver expects. Then the image/machine/conf should only have to include the wandboard-wifi-support recipe. I really don't think that renaming the .bin file makes the linux-firmware recipe machine-specific, but I think it should be done in the packages-split step when it is filtering out the bcm4329-specific files for inclusion into the image. That way, the user through the selection of linux-firmware-bcm4329 definitely gets the bcm4329 firmware file. John On 3/16/13 9:31 AM, Otavio Salvador wrote: > On Sat, Mar 16, 2013 at 10:45 AM, John Weber wrote: >> Adds linux-firmware bbappend recipe to provide support for the Broadcom >> BCM4329 Wifi device. Also adds a .txt file for nvram support. >> >> Signed-off-by: John Weber > > Thinking about how it was done, I'd say you could do it: > > * Make this to split the binaries but without renaming it > > * Add a new recipe (let's say wandboard-wifi-support) which rdepends > on the binary package and installs the .txt file for nvram as well. > > So we avoid to make linux-firmware machine specific. We cannot have > more than one package with same contents in filesystem (without being > different recipe name) so we'd need to complicate it a lot, using the > extra recipe makes it easy. > >