From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Junio C Hamano <gitster@pobox.com>
Cc: git discussion list <git@vger.kernel.org>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH] sha1_name: pass object name length to diagnose_invalid_sha1_path()
Date: Sun, 17 Mar 2013 12:38:44 +0100 [thread overview]
Message-ID: <5145AB44.8050704@lsrfire.ath.cx> (raw)
In-Reply-To: <7vzjy2qz6g.fsf@alter.siamese.dyndns.org>
Am 17.03.2013 08:10, schrieb Junio C Hamano:
>> @@ -1158,16 +1159,16 @@ static void diagnose_invalid_sha1_path(const char *prefix,
>> if (!get_tree_entry(tree_sha1, fullname,
>> sha1, &mode)) {
>> die("Path '%s' exists, but not '%s'.\n"
>> - "Did you mean '%s:%s' aka '%s:./%s'?",
>> + "Did you mean '%.*s:%s' aka '.*%.*s:./%s'?",
>
> Will squash an obvious fix in and apply.
Did I try to make a point there? Certainly not. It seems I need to go
back to http://vim-adventures.com/.
Thank you for spotting this!
René
prev parent reply other threads:[~2013-03-17 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-16 18:29 [PATCH] sha1_name: pass object name length to diagnose_invalid_sha1_path() René Scharfe
2013-03-17 7:10 ` Junio C Hamano
2013-03-17 11:38 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5145AB44.8050704@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.