From: Jonathan Cameron <jic23@kernel.org>
To: Ge GAO <ggao@invensense.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] using kfifo_in_spinlocked instead of separate code.
Date: Sun, 17 Mar 2013 20:15:14 +0000 [thread overview]
Message-ID: <51462452.9010904@kernel.org> (raw)
In-Reply-To: <1362439657-8691-1-git-send-email-ggao@invensense.com>
On 03/04/2013 11:27 PM, Ge GAO wrote:
> From: Ge Gao <ggao@invensense.com>
I added your sign off given it should have been here.
Please make sure to run checkpatch.pl against all patches
as it catches silly mistakes like this.
Applied to togreg branch of iio.git
>
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> index 331781f..7da0832 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c
> @@ -105,9 +105,8 @@ irqreturn_t inv_mpu6050_irq_handler(int irq, void *p)
> s64 timestamp;
>
> timestamp = iio_get_time_ns();
> - spin_lock(&st->time_stamp_lock);
> - kfifo_in(&st->timestamps, ×tamp, 1);
> - spin_unlock(&st->time_stamp_lock);
> + kfifo_in_spinlocked(&st->timestamps, ×tamp, 1,
> + &st->time_stamp_lock);
>
> return IRQ_WAKE_THREAD;
> }
>
prev parent reply other threads:[~2013-03-17 22:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 23:27 [PATCH] using kfifo_in_spinlocked instead of separate code Ge GAO
2013-03-17 20:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51462452.9010904@kernel.org \
--to=jic23@kernel.org \
--cc=ggao@invensense.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.