From: Danny Baumann <dannybaumann@web.de>
To: Aaron Lu <aaron.lu@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2 1/3] ACPI video: Fix brightness control initialization for some laptops.
Date: Mon, 18 Mar 2013 09:22:22 +0100 [thread overview]
Message-ID: <5146CEBE.3070909@web.de> (raw)
In-Reply-To: <5146C1B4.4050907@intel.com>
Hi,
>> diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
>> index 313f959..9c33871 100644
>> --- a/drivers/acpi/video.c
>> +++ b/drivers/acpi/video.c
>> @@ -222,7 +222,7 @@ static int acpi_video_device_lcd_set_level(struct acpi_video_device *device,
>> int level);
>> static int acpi_video_device_lcd_get_level_current(
>> struct acpi_video_device *device,
>> - unsigned long long *level, int init);
>> + unsigned long long *level, int raw);
>
> Why not bool?
For two reasons:
- It previous was int ;-)
- It allowed the invocations of this function to fit within one 80-char
line.
Neither reason is terribly strong, so if you prefer, I can convert this
argument to bool.
Regards,
Danny
next prev parent reply other threads:[~2013-03-18 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 10:10 [PATCH v2 1/3] ACPI video: Fix brightness control initialization for some laptops Danny Baumann
2013-03-15 10:10 ` [PATCH v2 2/3] ACPI video: Make logic a little easier to understand Danny Baumann
2013-03-15 10:10 ` [PATCH v2 3/3] ACPI video: Fix applying indexed initial brightness value Danny Baumann
2013-03-18 8:16 ` Aaron Lu
2013-03-18 8:26 ` Danny Baumann
2013-03-18 8:34 ` Aaron Lu
2013-03-18 7:26 ` [PATCH v2 1/3] ACPI video: Fix brightness control initialization for some laptops Aaron Lu
2013-03-18 8:22 ` Danny Baumann [this message]
2013-03-18 8:31 ` Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5146CEBE.3070909@web.de \
--to=dannybaumann@web.de \
--cc=aaron.lu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.