From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 18 Mar 2013 17:24:00 +0000 Subject: Re: [PATCH] ARM: shmobile: r8a7779: Add PCIe clock support Message-Id: <51474DB0.2010705@cogentembedded.com> List-Id: References: <1363624732-24660-1-git-send-email-phil.edworthy@renesas.com> In-Reply-To: <1363624732-24660-1-git-send-email-phil.edworthy@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hello. On 18-03-2013 21:20, phil.edworthy@renesas.com wrote: >>> Signed-off-by: Phil Edworthy >>> --- >>> Depends on "r8a7779: Add Display Unit clock support" >>> arch/arm/mach-shmobile/clock-r8a7779.c | 3 +++ >>> 1 files changed, 3 insertions(+), 0 deletions(-) >>> diff --git a/arch/arm/mach-shmobile/clock-r8a7779.c b/arch/arm/ >> mach-shmobile/clock-r8a7779.c >>> index 9ea6087..a017418 100644 >>> --- a/arch/arm/mach-shmobile/clock-r8a7779.c >>> +++ b/arch/arm/mach-shmobile/clock-r8a7779.c >> [...] >>> @@ -182,6 +184,7 @@ static struct clk_lookup lookups[] = { >>> CLKDEV_DEV_ID("sh_mobile_sdhi.2", &mstp_clks[MSTP321]), /* SDHI2 > */ >>> CLKDEV_DEV_ID("sh_mobile_sdhi.3", &mstp_clks[MSTP320]), /* SDHI3 > */ >>> CLKDEV_DEV_ID("rcar-du.0", &mstp_clks[MSTP103]), /* DU */ >>> + CLKDEV_DEV_ID("rcar-pcie.0", &mstp_clks[MSTP116]), /* PCIe */ >> Hm, why this name? Is there going to be a driver somewhere in >> drivers/pci/, >> and is there goiung to be more than one instance of PCIe? > Yes, I am writing a PCIe driver at the moment, But I assume it will live under arch/arm/mach-shmobile/, and will it be a true driver? > the same hardware is used > on a number of R-Car devices. For r8a7779 there is only one instance, Then remove ".0" please, and use 'id' field of -1 in the platform device (if there's going to be any). > Thanks > Phil WBR, Sergei