All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kazuya Mio <k-mio@sx.jp.nec.com>
To: Jan Kara <jack@suse.cz>
Cc: akpm@linux-foundation.org, adilger.kernel@dilger.ca,
	linux-ext4@vger.kernel.org
Subject: Re: bio splits unnecessarily due to BH_Boundary in ext3 direct I/O
Date: Tue, 19 Mar 2013 17:36:17 +0900	[thread overview]
Message-ID: <51482381.7010508@sx.jp.nec.com> (raw)
In-Reply-To: <20130307104854.GB6723@quack.suse.cz>

2013/03/07 19:48, Jan Kara wrote:
> Then we properly mark bio should be submitted only if we are mapping last
> part of the mapped extent from the filesystem. Can you give this change a
> try (full patch with changelog attached)?

Sorry for the late response.
After applying your patch, the problem I reported was fixed.

One matter for concern is that submit_bio() is called twice per one buffer_head.
Because submit_page_section() calls dio_bio_submit() before adding
the old page (sdio->cur_page) and the current page to struct dio_submit.
Does it work as required?

Regards,
Kazuya Mio


  reply	other threads:[~2013-03-19  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07  8:36 bio splits unnecessarily due to BH_Boundary in ext3 direct I/O Kazuya Mio
2013-03-07 10:48 ` Jan Kara
2013-03-19  8:36   ` Kazuya Mio [this message]
2013-03-19 19:31     ` Jan Kara
2013-03-21  8:43       ` Kazuya Mio
2013-03-29 17:15         ` Jan Kara
2013-04-01  8:25           ` Kazuya Mio
2013-04-09 15:40             ` Jan Kara
2013-04-10  2:59               ` Kazuya Mio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51482381.7010508@sx.jp.nec.com \
    --to=k-mio@sx.jp.nec.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.