From: Patrice CHOTARD <patrice.chotard@st.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"patches@linaro.org" <patches@linaro.org>
Subject: Re: [PATCH 4/5] pinctrl: ab8540: Staticize some symbols
Date: Tue, 19 Mar 2013 09:43:09 +0100 [thread overview]
Message-ID: <5148251D.8050802@st.com> (raw)
In-Reply-To: <1363674681-4015-4-git-send-email-sachin.kamat@linaro.org>
On 03/19/2013 07:31 AM, Sachin Kamat wrote:
> Silences the following warnings:
> drivers/pinctrl/pinctrl-ab8540.c:302:28: warning:
> symbol 'ab8540_alternate_functions' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-ab8540.c:379:32: warning:
> symbol 'ab8540_gpio_irq_cluster' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Patrice Chotard <patrice.chotard@stericsson.com>
> ---
> drivers/pinctrl/pinctrl-ab8540.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ab8540.c b/drivers/pinctrl/pinctrl-ab8540.c
> index 8ee1e8d..9867535 100644
> --- a/drivers/pinctrl/pinctrl-ab8540.c
> +++ b/drivers/pinctrl/pinctrl-ab8540.c
> @@ -299,7 +299,8 @@ static const struct abx500_function ab8540_functions[] = {
> *
> */
>
> -struct alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
> +static struct
> +alternate_functions ab8540_alternate_functions[AB8540_GPIO_MAX_NUMBER + 1] = {
> /* GPIOSEL1 - bit 4-7 reserved */
> ALTERNATE_FUNCTIONS(0, UNUSED, UNUSED, UNUSED, 0, 0, 0), /* no GPIO0 */
> ALTERNATE_FUNCTIONS(1, 0, UNUSED, UNUSED, 0, 0, 0), /* GPIO1, altA controlled by bit 0 */
> @@ -376,7 +377,7 @@ static struct pullud ab8540_pullud = {
> * GPIO43 to GPIO44
> * GPIO51 to GPIO54
> */
> -struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
> +static struct abx500_gpio_irq_cluster ab8540_gpio_irq_cluster[] = {
> GPIO_IRQ_CLUSTER(43, 43, AB8540_INT_GPIO43F),
> GPIO_IRQ_CLUSTER(44, 44, AB8540_INT_GPIO44F),
> GPIO_IRQ_CLUSTER(51, 54, AB9540_INT_GPIO51R),
Acked-by: Patrice Chotard <patrice.chotard@st.com>
next prev parent reply other threads:[~2013-03-19 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 6:31 [PATCH 1/5] pinctrl: abx500: Staticize some symbols Sachin Kamat
2013-03-19 6:31 ` [PATCH 2/5] pinctrl: ab8500: " Sachin Kamat
2013-03-19 8:41 ` Patrice CHOTARD
2013-04-09 7:55 ` Linus Walleij
2013-03-19 6:31 ` [PATCH 3/5] pinctrl: ab9540: " Sachin Kamat
2013-03-19 8:42 ` Patrice CHOTARD
2013-04-09 7:57 ` Linus Walleij
2013-03-19 6:31 ` [PATCH 4/5] pinctrl: ab8540: " Sachin Kamat
2013-03-19 8:43 ` Patrice CHOTARD [this message]
2013-04-09 7:59 ` Linus Walleij
2013-03-19 6:31 ` [PATCH 5/5] pinctrl: ab8505: " Sachin Kamat
2013-03-19 8:43 ` Patrice CHOTARD
2013-04-09 8:00 ` Linus Walleij
2013-03-19 8:28 ` [PATCH 1/5] pinctrl: abx500: " Patrice CHOTARD
2013-04-04 4:25 ` Sachin Kamat
2013-04-09 7:52 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148251D.8050802@st.com \
--to=patrice.chotard@st.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.