From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
netdev@vger.kernel.org, grant.likely@secretlab.ca,
kuninori.morimoto.gx@renesas.com,
devicetree-discuss@lists.ozlabs.org, magnus.damm@gmail.com,
kda@linux-powerpc.org, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v5] net: sh_eth: Add support of device tree probe
Date: Tue, 19 Mar 2013 17:02:39 +0400 [thread overview]
Message-ID: <514861EF.7050407@cogentembedded.com> (raw)
In-Reply-To: <20130319042229.GG21444@verge.net.au>
Hello.
On 19-03-2013 8:22, Simon Horman wrote:
>> [ Cc: Mark Rutland ]
>> On Tue, Mar 05, 2013 at 06:52:20AM +0900, Nobuhiro Iwamatsu wrote:
>>> This adds support of device tree probe for Renesas sh-ether driver.
>>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> Hi Iwamatsu-san,
>> could you please address the review by
>> Mark Rutland of the bindings in this patch.
>> The review was made for v2 but I believe it
>> is still applicable to v5.
>> http://www.spinics.net/lists/netdev/msg226454.html
> Ping.
I don't think converting this driver to device tree can be achieved
without unravelling the #ifdef mess first (which I'm currently doing).
Or at least the driver will look even uglier than today. So I see little use
in pinging Iwamatsu-san.
WBR, Sergei
next prev parent reply other threads:[~2013-03-19 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 21:52 [PATCH v5] net: sh_eth: Add support of device tree probe Nobuhiro Iwamatsu
2013-03-05 0:43 ` Simon Horman
2013-03-19 4:22 ` Simon Horman
2013-03-19 13:02 ` Sergei Shtylyov [this message]
2013-03-19 13:20 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514861EF.7050407@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=horms@verge.net.au \
--cc=kda@linux-powerpc.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.